From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753427AbcANKEu (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 05:04:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58687 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752809AbcANKEs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 05:04:48 -0500
Date: Thu, 14 Jan 2016 11:04:45 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
        lizefan@huawei.com, Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 3/9] perf build: Test correct path of perf in build-test
Message-ID: <20160114100445.GD31454@krava.brq.redhat.com>
References: <1452687442-6186-1-git-send-email-wangnan0@huawei.com>
 <1452687442-6186-4-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452687442-6186-4-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote:

SNIP

>  	( eval $$cmd ) >> $@ 2>&1 && \
>  	rm -f $@
>  
> +KBUILD_OUTPUT_DIR := ../..
> +ifneq ($(O),)
> +  KBUILD_OUTPUT_DIR := $(O)
> +endif
> +
>  make_kernelsrc:
>  	@echo "- make -C <kernelsrc> $(PARALLEL_OPT) tools/perf"
>  	$(call clean); \
>  	(make -C ../.. $(PARALLEL_OPT) tools/perf) > $@ 2>&1 && \
> -	test -x perf && rm -f $@ || (cat $@ ; false)
> +	test -x $(KBUILD_OUTPUT_DIR)/tools/perf && rm -f $@ || (cat $@ ; false)

do you miss one extra /perf in here? like it should be

   test -x $(KBUILD_OUTPUT_DIR)/tools/perf/perf

>  
>  make_kernelsrc_tools:
>  	@echo "- make -C <kernelsrc>/tools $(PARALLEL_OPT) perf"
>  	$(call clean); \
>  	(make -C ../../tools $(PARALLEL_OPT) perf) > $@ 2>&1 && \
> -	test -x perf && rm -f $@ || (cat $@ ; false)
> +	test -x $(KBUILD_OUTPUT_DIR)/tools/perf && rm -f $@ || (cat $@ ; false)

ditto

thanks,
jirka


>  
>  all: $(run) $(run_O) tarpkg make_kernelsrc make_kernelsrc_tools
>  	@echo OK
> -- 
> 1.8.3.4
>