From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753552AbcANKSW (ORCPT ); Thu, 14 Jan 2016 05:18:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226AbcANKSR (ORCPT ); Thu, 14 Jan 2016 05:18:17 -0500 Date: Thu, 14 Jan 2016 11:18:13 +0100 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, Jiri Olsa , Arnaldo Carvalho de Melo , Namhyung Kim Subject: Re: [PATCH 8/9] perf build: Select all feature checkers for feature-dump Message-ID: <20160114101813.GA3540@krava.brq.redhat.com> References: <1452687442-6186-1-git-send-email-wangnan0@huawei.com> <1452687442-6186-9-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452687442-6186-9-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 12:17:21PM +0000, Wang Nan wrote: > Set FEATURE_TESTS to 'all' so all possible feature checkers are' > executed. Without this setting the output feature dump file miss > some feature, for example, liberity. Select all checker so we won't > use a incomplete feature dump file. > > Signed-off-by: Wang Nan > Cc: Jiri Olsa > Cc: Arnaldo Carvalho de Melo > Cc: Namhyung Kim > --- > tools/perf/Makefile.perf | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 5d34815..a199fc4 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -166,6 +166,11 @@ endif > endif > > ifeq ($(config),1) > +ifdef MAKECMDGOALS > +ifeq ($(filter feature-dump,$(MAKECMDGOALS)),feature-dump) > +FEATURE_TESTS := all > +endif > +endif please put the changelog comment in here as well thanks, jirka