From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Qipeng Zha <qipeng.zha@intel.com>
Cc: linux-kernel@vger.kernel.org, lee.jones@linaro.org,
Huiquan Zhong <huiquan.zhong@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] mfd: lpss: Add PCI IDs for Intel Broxton B-Step platform
Date: Thu, 14 Jan 2016 12:57:17 +0200 [thread overview]
Message-ID: <20160114105717.GP6188@lahna.fi.intel.com> (raw)
In-Reply-To: <1452787951-69808-1-git-send-email-qipeng.zha@intel.com>
On Fri, Jan 15, 2016 at 12:12:31AM +0800, Qipeng Zha wrote:
> From: Huiquan Zhong <huiquan.zhong@intel.com>
>
> Add PCI IDs for Intel Broxton B-Step platform, which have same
> LPSS devices with A-Step.
>
> Signed-off-by: Huiquan Zhong <huiquan.zhong@intel.com>
> Signed-off-by: Qipeng Zha <qipeng.zha@intel.com>
Adding Andy if he has something to comment.
To me this looks good,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/mfd/intel-lpss-pci.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 5bfdfcc..b780d28 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -84,7 +84,7 @@ static const struct intel_lpss_platform_info bxt_i2c_info = {
> };
>
> static const struct pci_device_id intel_lpss_pci_ids[] = {
> - /* BXT */
> + /* BXT A-Step */
> { PCI_VDEVICE(INTEL, 0x0aac), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x0aae), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x0ab0), (kernel_ulong_t)&bxt_i2c_info },
> @@ -100,6 +100,23 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> { PCI_VDEVICE(INTEL, 0x0ac4), (kernel_ulong_t)&bxt_info },
> { PCI_VDEVICE(INTEL, 0x0ac6), (kernel_ulong_t)&bxt_info },
> { PCI_VDEVICE(INTEL, 0x0aee), (kernel_ulong_t)&bxt_uart_info },
> + /* BXT B-Step */
> + { PCI_VDEVICE(INTEL, 0x1aac), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x1aae), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x1ab0), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x1ab2), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x1ab4), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x1ab6), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x1ab8), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x1aba), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x1abc), (kernel_ulong_t)&bxt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x1abe), (kernel_ulong_t)&bxt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x1ac0), (kernel_ulong_t)&bxt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x1ac2), (kernel_ulong_t)&bxt_info },
> + { PCI_VDEVICE(INTEL, 0x1ac4), (kernel_ulong_t)&bxt_info },
> + { PCI_VDEVICE(INTEL, 0x1ac6), (kernel_ulong_t)&bxt_info },
> + { PCI_VDEVICE(INTEL, 0x1aee), (kernel_ulong_t)&bxt_uart_info },
> +
> /* APL */
> { PCI_VDEVICE(INTEL, 0x5aac), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x5aae), (kernel_ulong_t)&bxt_i2c_info },
> --
> 1.8.3.2
next prev parent reply other threads:[~2016-01-14 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 16:12 [PATCH] mfd: lpss: Add PCI IDs for Intel Broxton B-Step platform Qipeng Zha
2016-01-14 10:57 ` Mika Westerberg [this message]
2016-01-25 14:24 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114105717.GP6188@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=huiquan.zhong@intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox