From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754739AbcANOrf (ORCPT ); Thu, 14 Jan 2016 09:47:35 -0500 Received: from foss.arm.com ([217.140.101.70]:46814 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbcANOre (ORCPT ); Thu, 14 Jan 2016 09:47:34 -0500 Date: Thu, 14 Jan 2016 14:47:12 +0000 From: Mark Rutland To: Jan Glauber Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jan Glauber Subject: Re: [RFC PATCH 3/5] arm64: dts: Add Cavium ThunderX specific PMU Message-ID: <20160114144711.GC27039@leverpostej> References: <9b05a1866d37f3c1af0c6ae5835df810342ff558.1452766568.git.jglauber@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b05a1866d37f3c1af0c6ae5835df810342ff558.1452766568.git.jglauber@cavium.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, As it's the middle of the merge window, it will be a while before this sees a full review. In future, it would be better to wait until -rc1 before posting new patches (appropriately rebased). I did spot one thing however. On Thu, Jan 14, 2016 at 01:55:43PM +0100, Jan Glauber wrote: > Add a compatible string for the Cavium ThunderX PMU. > > Signed-off-by: Jan Glauber > --- > Documentation/devicetree/bindings/arm/pmu.txt | 1 + > arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt > index 5651883..9bd0a33 100644 > --- a/Documentation/devicetree/bindings/arm/pmu.txt > +++ b/Documentation/devicetree/bindings/arm/pmu.txt > @@ -25,6 +25,7 @@ Required properties: > "qcom,scorpion-pmu" > "qcom,scorpion-mp-pmu" > "qcom,krait-pmu" > + "cavium,thunderx-pmu" > - interrupts : 1 combined interrupt or 1 per core. If the interrupt is a per-cpu > interrupt (PPI) then 1 interrupt should be specified. > > diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > index 9cb7cf9..84ac556 100644 > --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > @@ -360,6 +360,11 @@ > <1 10 0xff01>; > }; > > + pmu { > + compatible = "cavium,thunderx-pmu", "arm,armv8-pmuv3"; In current dts, "cavium,thunder" is used as the CPU compatible string. Please decide whether you want to call the CPU "Thunder", or "Thunder-X", and ensure that all compatible strings are consistent. Please also ansure that any related names exposes to userspace (i.e. e.g. the PMU name) follow this consistent naming. Thanks, Mark. > + interrupts = <1 7 4>; > + }; > + > soc { > compatible = "simple-bus"; > #address-cells = <2>; > -- > 1.9.1 >