From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754797AbcANO6X (ORCPT ); Thu, 14 Jan 2016 09:58:23 -0500 Received: from mail.kernel.org ([198.145.29.136]:60799 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbcANO6V (ORCPT ); Thu, 14 Jan 2016 09:58:21 -0500 Date: Thu, 14 Jan 2016 11:58:17 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test Message-ID: <20160114145817.GU18367@kernel.org> References: <1452777243-178927-1-git-send-email-wangnan0@huawei.com> <1452777243-178927-4-git-send-email-wangnan0@huawei.com> <20160114145021.GT18367@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160114145021.GT18367@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jan 14, 2016 at 11:50:21AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jan 14, 2016 at 01:13:57PM +0000, Wang Nan escreveu: > > If an 'O' is passed to 'make build-test', many 'test -x' and 'test -f' > > will fail because perf resides in a different directory. Fix this by > > computing PERF_OUT according to 'O' and test correct output files. > > For make_kernelsrc and make_kernelsrc_tools, set KBUILD_OUTPUT_DIR > > instead because the path is different from others ($(O)/perf vs > > $(O)/tools/perf). > > So, before this patch: Also, while trying to get this to work, I found these places lacking the O= prefixing, right? diff --git a/tools/perf/tests/make b/tools/perf/tests/make index e74c86b00c31..67842900482e 100644 --- a/tools/perf/tests/make +++ b/tools/perf/tests/make @@ -59,7 +59,7 @@ has = $(shell which $1 2>/dev/null) # standard single make variable specified make_clean_all := clean all -make_python_perf_so := python/perf.so +make_python_perf_so := $(PERF_O)/python/perf.so make_debug := DEBUG=1 make_no_libperl := NO_LIBPERL=1 make_no_libpython := NO_LIBPYTHON=1 @@ -82,9 +82,9 @@ make_tags := tags make_cscope := cscope make_help := help make_doc := doc -make_perf_o := perf.o -make_util_map_o := util/map.o -make_util_pmu_bison_o := util/pmu-bison.o +make_perf_o := $(PERF_O)/perf.o +make_util_map_o := $(PERF_O)/util/map.o +make_util_pmu_bison_o := $(PERF_O)/util/pmu-bison.o make_install := install make_install_bin := install-bin make_install_doc := install-doc