From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755155AbcANQV1 (ORCPT ); Thu, 14 Jan 2016 11:21:27 -0500 Received: from mail-bl2on0069.outbound.protection.outlook.com ([65.55.169.69]:64186 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752418AbcANQVZ (ORCPT ); Thu, 14 Jan 2016 11:21:25 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@caviumnetworks.com; Date: Thu, 14 Jan 2016 17:06:05 +0100 From: Jan Glauber To: Mark Rutland CC: Jan Glauber , Will Deacon , , Subject: Re: [RFC PATCH 3/5] arm64: dts: Add Cavium ThunderX specific PMU Message-ID: <20160114160605.GA10182@hardcore> References: <9b05a1866d37f3c1af0c6ae5835df810342ff558.1452766568.git.jglauber@cavium.com> <20160114144711.GC27039@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160114144711.GC27039@leverpostej> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [109.193.45.215] X-ClientProxiedBy: DB4PR03CA0011.eurprd03.prod.outlook.com (25.160.39.149) To SN2PR0701MB765.namprd07.prod.outlook.com (25.160.15.143) X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB765;2:f6SaFEOPe01hZS6oE53Ed5RZl1z9j7xH4NLdGZIYqV0ZaE1Qgdr17xEL6WR3N2iVFpdWb0EhR31DHpQHrANosSV/k6qZMaHVt2Q0Aa0l0TD+DUNZJt1Eemxrn7auBCmg47XXHC1/y7MrbcjEdEg+GQ==;3:vgPiBA3spyBr/KO4il5tBQ40VWc2fI9+8hZVcufP8dfCSyeMP3yd4Pn9Yszxu0FcNrjdFu5WMJtnM9JT1LXCRxxJq7+4+zrq1dnzpkwt8QikjoC9JF4CZKh9pLdwmfyn;25:7nU7HQ4MAI4FMKRAnEAvTURfQVCQYmBII45Su3ST/H8/pqVD9k9Unjz2xIXskWmUXp26y5Ws29LSpM7ClgekSag2INqqI8q1mYYhDPKYdjC9rkXC76b5bMMkJFoZWzboEiUq0pMcOtVOQNs5poN4YBzswrR4ifKnvdbMm1dNUDVbSsKzr8rakxmmBpQougrOiDI1I5mOE42a60qXM1PWuVrxmocV9EYN3gyr8x/WtxZRWM49YkqFWCsEsTaJ6MAv X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB765; X-MS-Office365-Filtering-Correlation-Id: eb63e5b7-1b58-4c4d-14ca-08d31cfca3d0 X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB765;20:tPHpfao7TBcMEtmXIvzwBLLOP8p8rmgXrOFbma792RRWwxdmVq4Duzhe6lm7WKM2+Lu7XwXgiA/XXevDaqWIamy8bzvqbQz6OB/tdgLKlIVlaSY7x3ucCdm+kh2+JhWrssELzcaaEJt0RNJBMz/hWZ4aMZ5L7nhJWtJPM0Qvk+5KVRS8N9PrpFW64DCxGKx99j3RHYFG9h3q9Xv4SnGyxyWR06p6r7i8jXqQm94dk1dwf8oSV4ES+gYldoP00icNVjpE0PI205fdMTwr6HrhnAv8W/UQS5TMhc7pm/VoxUImwwNCqXIG/uAkZGZKoRmQx6GOfL7vFL/nbeDS1okhzvIHBLoOfZiE9ozVT/OXjOtfkuiufh3kItxshUBrz9e7UJuH+0bBipTcIiPJuSelO+c1YCo28l5Opz8oCVWkaSKNu6tFxPgLEcEwsqVY4czHDZzbHtv5/zNE2VK/Wqcijog9RRI3G2De1wqqmG9S2TRxmWqNwUSwDMqa13GUEWazAsegSfEn9hq4v3fTdhtAYS7mWBmnj9QOQg8rRifbRD0qBAjg8YD8eBjpxHWUy6PFZltVsaw86fBlzit8Du9GFxMu8WFOytWTYa/WSY7zsQw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001)(10201501046);SRVR:SN2PR0701MB765;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB765; X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB765;4:9n5bJT/jioHd6jK3ALaCtasCHOmn4DJIcezzvxrP+4+t1l3D3B9AR7DbsQP9VxF/17GqIJhqBwUogB2n9mR91m33jdcM+qMDHXlQ7CvSFrST8URgkJPxG7WIjYyDJbf/ywmnPZxi8yzav4qq4YbgmMk+MSUEjlE29HG2l1xDAczU7DJf9ARhhOwPFuFq5zPWHzrUhSgamChiq1Y6sKFziK0vrXy1i9I9hnDrb9qb9VVfGeq8k+PdkebCVYnV/z8IXNp8H8bAd95mmKDMErVnE2znzx1A71qK3HizBYnrlCKrrH39MDsEQam/tzX/cL1OU0DtdfV3RWDUb41MQx6DixPnDayznoNgKyuBNCD4dQjkxH5Y3kt0Qelrq+YSEocV X-Forefront-PRVS: 08213D42D3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(199003)(24454002)(50466002)(110136002)(33716001)(97756001)(47776003)(46406003)(54356999)(575784001)(50986999)(77096005)(106356001)(42186005)(5001960100002)(40100003)(92566002)(86362001)(4326007)(33656002)(76176999)(23726003)(2906002)(1096002)(3846002)(66066001)(2950100001)(122386002)(87976001)(19580395003)(101416001)(19580405001)(4001350100001)(5008740100001)(586003)(97736004)(189998001)(5004730100002)(105586002)(83506001)(81156007)(1076002)(6116002)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR0701MB765;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR0701MB765;23:4V/TyJPlH1883Oy+oohsJzyQtif1Wldhb/vKCoZM?= =?us-ascii?Q?5qAVyZIrYpKNrLaZWa3BzL5+c6n14bjTUatrLtrfdpCQAdFgk7ZMfkuvg0cn?= =?us-ascii?Q?GF5U0f5RwodadASO0/UvHG5M/o2zLlruptP92R52hyTODwwXZPPptEsxM8OL?= =?us-ascii?Q?Jviap8LwX/pzduY/ye+rOS6vfW1AsY2LdRXKmKIECngcJjD2bMRxpy1VYwBW?= =?us-ascii?Q?IDl0HQah/vqv/nBg4d+wNN/m4ZULAMnQNFT3AJ1ggYC7oMdwO3Gtj1uRmzV9?= =?us-ascii?Q?Arx3phY/ZHIRXMZTZVB2q60Zhgi6/GMIRAe4bDSiTGqSEBegFCX8ickj2o2H?= =?us-ascii?Q?BMDfLWYuOfR9acgyfto45Ou+WvyuC/MsjBTtrGqahWfWVTtgGuBzhCD9eU1n?= =?us-ascii?Q?ddLzI9Bmjkuye0/7mIaLAP5B7rYoehrGIqlH+FsZ2dtsjNaxtvoXVwbggeu/?= =?us-ascii?Q?+W0iv8GwqCXhey44T+5Xe8XUup4wyf/mesq/sEACf62nfrgy9Y3inz0/Bp3I?= =?us-ascii?Q?KGjUkoMuemRGGHO9sJNPb6YmCR9tN/ao3vCh9IFw0eA715G/dnzD5NXv4U18?= =?us-ascii?Q?iDQ741onWHzRQBCqxFEbi8/T+ja6UrvONXxqqTHFxkOS6rajAHOEzwd//DUT?= =?us-ascii?Q?+JKFInmJumj1atj7P+dgbdTGOis5/L3WG15pQcGZTS4Q+NX0VPPfhWU28hjp?= =?us-ascii?Q?L8ZjLkrnOTko8yPbsdBR45cujV0Be3m1JwAqLFXFMWOLHiCV8CkuN1FX+/SC?= =?us-ascii?Q?ge2WpJBET+XtRvhGOjEQ5zU50i4fESC791w0DYK7X0nU/uF/+0kzwW3vu5TV?= =?us-ascii?Q?ZUQ/AawXcUdNm0CH91Pu0kpM3udwN0l1m8LNvIqZgnq3UNe2JzARL36pGctT?= =?us-ascii?Q?EVCY40Qa/zaFPeQyqAm4MXd9ldgjpR2YKElPxul4UfOgyGGKW6Nf3ztI9yHw?= =?us-ascii?Q?oMmAYgsodElcNJk9AuMXEJ3Fh8C2zKn4PuqFUj+PBudpU/R4CmG7Myl79K6N?= =?us-ascii?Q?JLrWMwM2L7OCRspZHkv1KcTBaBZVGb9ERgEZC615UsrU1o9NBfPA1zuGWok0?= =?us-ascii?Q?ievl/wAPvV7HvDscqxCvA8F331HIVnQxuNCi/sXd6wdzzF6qrrE8Duz3ewDD?= =?us-ascii?Q?4En6oxhjksu5M67lEI/wdUQoRdwFGeob5lCqzj3l1dBlGuPWDur2jsBnLYoS?= =?us-ascii?Q?fLRI1Q97o/Cc0QE=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB765;5:Pl5VDmvG736hGT1+sPg35aZrE5JnFZxVIlPRmxLXD3iRnuI5FVmdEgmxIuiQw+v5WM8II0CvNtL9VerXzN/IytxdOSubLzTw+fCA+8joUQ2Mz/grJrosmfS1w7fn09e/sQ0vnSPDEiym++cvNbowvQ==;24:wDOkKcG9qNqVcyytOKvNaojTqfe42iqM5xWq9FAYFXafvpXG5Q2l3uYbEzOJ0HfU3FznHlgTRcM7etjI2sLiZUGBPy4UCQxauPD9r8TWIJ0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2016 16:06:17.9249 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB765 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2016 at 02:47:12PM +0000, Mark Rutland wrote: > Hi, > > As it's the middle of the merge window, it will be a while before this > sees a full review. In future, it would be better to wait until -rc1 > before posting new patches (appropriately rebased). OK, fair enough. I'll repost after -rc1 if the patches don't fit anymore. > I did spot one thing however. > > On Thu, Jan 14, 2016 at 01:55:43PM +0100, Jan Glauber wrote: > > Add a compatible string for the Cavium ThunderX PMU. > > > > Signed-off-by: Jan Glauber > > --- > > Documentation/devicetree/bindings/arm/pmu.txt | 1 + > > arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 5 +++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt > > index 5651883..9bd0a33 100644 > > --- a/Documentation/devicetree/bindings/arm/pmu.txt > > +++ b/Documentation/devicetree/bindings/arm/pmu.txt > > @@ -25,6 +25,7 @@ Required properties: > > "qcom,scorpion-pmu" > > "qcom,scorpion-mp-pmu" > > "qcom,krait-pmu" > > + "cavium,thunderx-pmu" > > - interrupts : 1 combined interrupt or 1 per core. If the interrupt is a per-cpu > > interrupt (PPI) then 1 interrupt should be specified. > > > > diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > index 9cb7cf9..84ac556 100644 > > --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > @@ -360,6 +360,11 @@ > > <1 10 0xff01>; > > }; > > > > + pmu { > > + compatible = "cavium,thunderx-pmu", "arm,armv8-pmuv3"; > > In current dts, "cavium,thunder" is used as the CPU compatible string. > > Please decide whether you want to call the CPU "Thunder", or > "Thunder-X", and ensure that all compatible strings are consistent. I think we should keep the already existing name then. thanks, Jan