From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756026AbcANQ14 (ORCPT ); Thu, 14 Jan 2016 11:27:56 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:54278 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755297AbcANQ1x (ORCPT ); Thu, 14 Jan 2016 11:27:53 -0500 Date: Thu, 14 Jan 2016 17:27:41 +0100 From: Andrew Lunn To: SF Markus Elfring Cc: Dan Carpenter , "David S. Miller" , Igal Liberman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] fsl/fman: Delete one function call "put_device" in dtsec_config() Message-ID: <20160114162741.GC19773@lunn.ch> References: <5696BFAD.9030905@users.sourceforge.net> <20160113213537.GD4399@mwanda> <20160113220923.GE5527@lunn.ch> <5697B81E.4050303@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5697B81E.4050303@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2016 at 04:00:46PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 14 Jan 2016 15:46:28 +0100 > > The Coccinelle semantic patch script "deref_null.cocci" pointed a problem > out in the implementation of the function "dtsec_config". > > A null pointer was assigned to the data structure member "tbiphy" of the > variable "dtsec" if a matching device was not found. > A call of the function "put_device" was unnecessary then because > a previous call of the function "get_device" was not triggered. > Thus remove the function call "put_device" after the printing of the > desired error message. > > Signed-off-by: Markus Elfring Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Reviewd-by: Andrew Lunn Andrew > --- > drivers/net/ethernet/freescale/fman/fman_dtsec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c > index 6b1261c..7c92eb8 100644 > --- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c > +++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c > @@ -1434,7 +1434,6 @@ struct fman_mac *dtsec_config(struct fman_mac_params *params) > dtsec->tbiphy = of_phy_find_device(params->internal_phy_node); > if (!dtsec->tbiphy) { > pr_err("of_phy_find_device (TBI PHY) failed\n"); > - put_device(&dtsec->tbiphy->mdio.dev); > goto err_dtsec_drv_param; > } > > -- > 2.6.3 >