From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756246AbcANSL5 (ORCPT ); Thu, 14 Jan 2016 13:11:57 -0500 Received: from mail-by2on0053.outbound.protection.outlook.com ([207.46.100.53]:25423 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753337AbcANSL4 (ORCPT ); Thu, 14 Jan 2016 13:11:56 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yuri.Norov@caviumnetworks.com; Date: Thu, 14 Jan 2016 21:11:43 +0300 From: Yury Norov To: , , , CC: , , , , , , , , , , , Subject: Re: [PATCH v6 20/21] all: s390: make compat wrappers the generic solution Message-ID: <20160114181143.GA11048@yury-N73SV> References: <1452792198-10718-1-git-send-email-ynorov@caviumnetworks.com> <1452792198-10718-21-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1452792198-10718-21-git-send-email-ynorov@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [95.143.213.121] X-ClientProxiedBy: AM3PR03CA047.eurprd03.prod.outlook.com (10.141.191.175) To BY2PR07MB616.namprd07.prod.outlook.com (10.141.222.156) X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB616;2:fSWYR08JqkAynaddrrBpvcsYZnWLxPKcNYdhKSuj44Q3RStVuj+PaEhQqa9v+GndSHSJcC0yp0Hrw+GWxWpSLGq0zrMsgFURLvoo/eANegP2gHfzfPmvWyX7SpyRhQr8yso60EjxZ/qngkc7iYB32A==;3:5NpDazVSGg0rT+q8BRLyuBcjXZveu+/FGwjkoFkdruBPUn781CIl0Bvjl4cabM+xGj+pnRVdbuDZDZRcZRiA8GVbdc7/UjYD5NksDYNGyQh3Knm6Dz+bgl1YOLq2rgIL;25:PZHu7GVdArxlY+YzL3MOMFLzWjcCJ6pCYuLeCu3aVW6jGIrf2cl1L4/+WBDRukTAYJav+4uJ3ZgERRjJgGBDXfMGxeHZSOrAyhPlJJAwEt7aJNIwlr1aXGtT1+NZrTcoF3sZ3KWQqdzris7mm/ZxYTZoKJHNgyLmPJQ0wSg4lwmyInJCwGMCv/MkAp1vXOz83WqFo0ZfkAcApkovkegUkpRZizQNU7NLR84jnfEjeqdrSIeWPXGG1mOD3onzkmGj X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB616; X-MS-Office365-Filtering-Correlation-Id: 899b58a5-0f8d-42f8-0b3e-08d31d0e2f00 X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB616;20:/kdJnmQSGdvRyXfdo4hvxscGKXjG3sLlIJuNSRAhvHeSmtvC6wn19QyddruNAVE/bcOVcZMxGWifP2ibf9cOddTic5Ms44c4hRl13EjUH5py+Ch+J3cyjwGUw+ux19K+uVlZbkeC9WL6a4sbkZ7FMOtETLP7G1iZl6XnFCSI+KmvDwcsgCPqzLGOCW7v7cBLjjYa+112zOqsdXq7x++V4tl3p8L0rC4Y0EF1agsD33PIS2jac/RCOm/sr6qZ6ghC3tAosDT8kEjINWJvmzT0+YOSt+zEWJRjWQb7ii9O2FwkPkC3lQhebqFoBrn6AWF56WkbgHiHBUWbMTb/6DbkhIO8qO5r0kwQHYtoBo/MDI+VKNHmmeUYvyViAoRwSwQxGrr0cV5WWDrgDMscGUHCJWBNlnPEFrhbUmC4w/Ui9m/RrPDwCt6+/Ar/BvrCafHWb0/wWkO6qVP+rgwluQiUCn0bASLxQN/WiAD02PhwxU6CQHRTGvX7f+gibwTaWpQviz0mW1qwJGgJ+5lwDKK1TklDM98MJmwliaWcsI7VSPSIy1Gmk18aAoFF4AIqAMDPAj+xhayOgRSNYk5FCSVBQ1PAnckiz7J5zR46+q/n4po= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236414709691187); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:BY2PR07MB616;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB616; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB616;4:sFGIQIjmoK7qwUYR0l/VCz009SIYPJ2ZtW+JWbhvb1Funs7BcYO7lCt92Hx/prfngERvLca2BtNdW8z3KParPYPlADznxLM+SS7547Cx8+yIzmYHIp3/MKJ9YA+v1v3YDDla/ZRsoJM0bouf8eKqdCfoD6tY3Tq8zpf+YIjNZbuSXCUJsCFD32PtgwmIG79sc0TiiSX+inkKJiKDi5ZF21KuBZ5mZWfRxrmvmCwk+3J3DrOLcsn6rLl3jAnOvgiOK8NQ0W/V69zamTkPQm+H2qHJZ7k+K38KEhZxUlzaC8nlgIO4dH6uhKwZwe6Ud3PkiGBr6kpJZY9WbJWBpsJo1fc/3dED0UIH4NG792EjgmhzDSUZ1vbQnFZXfAf1WfrtnSpIkaAfPnuXhjsZa15BEY7xazO/YPEdNIGsKF5J8J4= X-Forefront-PRVS: 08213D42D3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(199003)(24454002)(189002)(1096002)(23726003)(3846002)(97736004)(87976001)(2950100001)(97756001)(92566002)(4326007)(6116002)(81156007)(1076002)(586003)(76176999)(5001960100002)(83506001)(47776003)(50986999)(189998001)(106356001)(33656002)(77096005)(5001770100001)(122386002)(33716001)(101416001)(66066001)(54356999)(105586002)(5004730100002)(2201001)(4001350100001)(50466002)(19580405001)(19580395003)(2906002)(76506005)(42186005)(40100003)(5008740100001)(46406003)(41533002)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR07MB616;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR07MB616;23:/e3gLduAv+LY5EaQn5oTl/uIK4N21MtkMURTGPfQ8m?= =?us-ascii?Q?OeqJ99kWH1pgW+Ljz4ItptEcad1i8coNM6bAcY9D8ebV5+Q8erOZciXztyEe?= =?us-ascii?Q?JPhNz3bA9epRhcp441t/RykDGWgU/KsftioZRKxrvOnlg7IG0ZdIEEFa0AOV?= =?us-ascii?Q?j0ef4pR89SB88pBHlMDvteE7lyB6ecbZF6x1LABSRVIAa5VuNUKO2SZPOqYX?= =?us-ascii?Q?B4jPr4s27h8lZIOGLROTmO/tUW9RsF3IFilcVybUx8xgx+gFuMT1cPyhitVX?= =?us-ascii?Q?tanAY8MjWX1+qoHOd+pa/H3s1vfCXhUcJATvVIv07qqPrcJFwREq6tCw0IVB?= =?us-ascii?Q?0jBn8AbCU20F0Cqxm2I4HHNvN/mASLkTNBT9YElSodR/ur9thwV/8UhVhdTU?= =?us-ascii?Q?uZzfRTG4MTMY/FchQG3/in/Ei+9IKcOyq/DZdYWBpz4wjFlS7wcsOPoDasap?= =?us-ascii?Q?hHJ7/a++GwMbFKcKRE8cWyJrSqpxROhXs1If3Iq22IIKzbk9Oo25fmm8hBGE?= =?us-ascii?Q?ARhDN/QAOsIlUSSf5BLwfbGtyMKaNpSmUecg3WvnzRtIL9i/TkrcbED1J5XS?= =?us-ascii?Q?+qhpfYGf6j153CXyZQyw7DXezBNFBkFkcG1L8GyTe9n5pDj3y8aRHN3U8jD1?= =?us-ascii?Q?L1tpw7XYJBxxs4BZSJb0fxviunHQBkAJtSArGa65iWmycWb3Pxt/yThuIXlz?= =?us-ascii?Q?UifbxQWmBrQ6i4M5Y9ltHeAzZRSHoaZ5umW0V7AnUisH4gM8dyjgarEGGL1n?= =?us-ascii?Q?sqj/W4ZMCKl68qAAj5VEM+LZpyZKAplSw1aN46b4JuqpEp01TSAabRbU1LIn?= =?us-ascii?Q?D1whNq8FJ/TsKEP8JC/Kv1+qYDxIK+a8B3bF92oAtUiNliSpCkgh59xMqTh3?= =?us-ascii?Q?LFKNHFMlrBV4D758ilDi/Po0RQCS9jbwdL530mHwTtCIT/0E5ZTZJBEX1BCA?= =?us-ascii?Q?QDPQQ2qcqvrD5sn1hTRUq5RpiR8itmWEV6xvx5ZPG7f015XoBPtniwGvwOiv?= =?us-ascii?Q?gjq2NZt+CPjBcwzYVPjFS+T+0t3fPLMxR8XnAz292g+BmyRmh42VHa/5XjAI?= =?us-ascii?Q?IuV8kKCAzvyAGSfAher8eQ2C7A7vZKt0YxRJZdSsqadn/0GN/AG2hcaE905R?= =?us-ascii?Q?4107rNNyBtFbP4zsowCy00txy/LRcAEDHqiC9EFwTVWbr0rWDKTOUepfrhC/?= =?us-ascii?Q?4/++iYIQHY3MlGf+stnQDVW5y5EarbyWYBz2VDP4zZZK5bOrJlMaPLBA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB616;5:Yy9T25+BxMKeIBqzd9Zg7TSNmnjyDAqsCxOa8Fq4qsn8eazT0X2twM+SD08xz0WyI26PkJXHA11UBsHVO3k0fxvEThmRwqyRX4Ppsw3uel9JMJROhWjs2nObQUas2y2TYciIWPlQa06xYilcTbbizw==;24:oYgGdp7FbdlbyZorSLHFBxPI2+b56CWbcG8BKqpx8iOpc2xOHNHQtYcGeb18oVr4RfVg4IDjSD21PEbbrnfvZ2aECs1au+HmWdIjMtrnads= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2016 18:11:54.0432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB616 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2016 at 08:23:17PM +0300, Yury Norov wrote: > The problem that makes us to use wrappers is that some compat > architectures allows user code to access top halves of registers. > This is not a problem for syscalls that are already handled by compat > code, or for that who has types of the same size in kernel and > userspace. In case of lp64/ilp32 the problem is in pointer types, long, > unsigned long. > > S390 folks already have the solution for it. In this patch, > it is turned to be general, as arm64/ilp32 needs it too. > > Build-tested on s390. > > Signed-off-by: Yury Norov > --- [...] > +#ifndef __SC_COMPAT_CAST > +#define __SC_COMPAT_CAST(t, a) ((t)(long) ((t)(-1) < 0 ? (s32)(a) : (u32)(a))) > +#endif It should be like: #define __SC_COMPAT_CAST(t, a) ((t) ((t)(-1) < 0 ? (s64)(s32)(a) : (u64)(u32)(a)))