From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161057AbcANTNO (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 14:13:14 -0500
Received: from casper.infradead.org ([85.118.1.10]:41743 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754290AbcANTMm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 14:12:42 -0500
Date: Thu, 14 Jan 2016 20:12:38 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Luca Abeni <luca.abeni@unitn.it>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@arm.com>
Subject: Re: [RFC 5/8] Track the "total rq utilisation" too
Message-ID: <20160114191238.GA6357@twins.programming.kicks-ass.net>
References: <1452785094-3086-1-git-send-email-luca.abeni@unitn.it>
 <1452785094-3086-6-git-send-email-luca.abeni@unitn.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452785094-3086-6-git-send-email-luca.abeni@unitn.it>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 14, 2016 at 04:24:50PM +0100, Luca Abeni wrote:
> +	if (dl_rq->running_bw > dl_rq->this_bw) {
> +		WARN_ON(1);
> +		dl_rq->running_bw = dl_rq->this_bw;
> +	}

FWIW you can write this as:

	if (WARN_ON(dl_rq->running_bw > dl_rq->this_bw))
		dl_rq->running_bw = dl_rq->this_bw;