From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754155AbcANUZ6 (ORCPT ); Thu, 14 Jan 2016 15:25:58 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:52788 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbcANUZ5 (ORCPT ); Thu, 14 Jan 2016 15:25:57 -0500 Date: Thu, 14 Jan 2016 15:25:21 -0500 From: Johannes Weiner To: Andrew Morton Cc: Michal Hocko , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] mm: memcontrol: basic memory statistics in cgroup2 memory controller Message-ID: <20160114202521.GB20218@cmpxchg.org> References: <1452722469-24704-1-git-send-email-hannes@cmpxchg.org> <1452722469-24704-2-git-send-email-hannes@cmpxchg.org> <20160113144930.b20ed63f1c6a28730f66eccd@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160113144930.b20ed63f1c6a28730f66eccd@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 02:49:30PM -0800, Andrew Morton wrote: > > @@ -5095,6 +5107,46 @@ static int memory_events_show(struct seq_file *m, void *v) > > return 0; > > } > > > > +static int memory_stat_show(struct seq_file *m, void *v) > > +{ > > + struct mem_cgroup *memcg = mem_cgroup_from_css(seq_css(m)); > > + int i; > > + > > + /* Memory consumer totals */ > > + > > + seq_printf(m, "anon %lu\n", > > + tree_stat(memcg, MEM_CGROUP_STAT_RSS) * PAGE_SIZE); > > Is there any reason why this won't overflow a longword on 32-bit? It will, I don't know what I was thinking there. Fixed in the update.