From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757050AbcANW7B (ORCPT ); Thu, 14 Jan 2016 17:59:01 -0500 Received: from mail.skyhub.de ([78.46.96.112]:36313 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756952AbcANW7A (ORCPT ); Thu, 14 Jan 2016 17:59:00 -0500 Date: Thu, 14 Jan 2016 23:58:43 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] x86/mcheck/AMD: Set MCAX Enable bit Message-ID: <20160114225842.GM19941@pd.tnic> References: <1452809140-3328-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1452809140-3328-6-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160114224606.GK19941@pd.tnic> <56982706.502@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56982706.502@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2016 at 04:53:58PM -0600, Aravind Gopalakrishnan wrote: > Well McaX is name of the field in the MSR. I retained the "SMCA" prefix as What does that McaX mean, btw? > these are all still part of the ScalableMCA changes. > I would prefer if "MCAX" is retained as it is indicative of which bit we are > touching. So how about just MCAX_EN_OFF ? If we're going to have a bunch of defines belonging to SMCA, then we're better having them all start with SMCA_ after all, I guess. But please make sure you have comments over their definitions explaining what those bits are. When an outsider is reading those patches and SMCA, MCAX start appearing left and right, his head most likely starts to spin. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.