From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757155AbcANXGv (ORCPT ); Thu, 14 Jan 2016 18:06:51 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:49276 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757076AbcANXGt (ORCPT ); Thu, 14 Jan 2016 18:06:49 -0500 Date: Thu, 14 Jan 2016 15:06:47 -0800 From: Darren Hart To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Matthew Garrett , Gabriele Mazzotta , Andy Lutomirski , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dell-wmi: Process only one event on devices with interface version 0 Message-ID: <20160114230647.GG1989@malice.jf.intel.com> References: <1450991926-20937-1-git-send-email-pali.rohar@gmail.com> <1451942796-26574-3-git-send-email-pali.rohar@gmail.com> <20160112111439.GA7630@eudyptula.hq.kempniu.pl> <201601121849.44256@pali> <20160112201246.GA19348@eudyptula.hq.kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160112201246.GA19348@eudyptula.hq.kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2016 at 09:12:46PM +0100, Michał Kępień wrote: > > > Wouldn't it be a bit more clear if we clamped buffer_size before > > > setting buffer_end? E.g. like this: > > > > > > if (buffer_size == 0) > > > return; > > > > > > if (dell_wmi_interface_version == 0 && > > > buffer_size > buffer_entry[0] + 1) > > > buffer_size = buffer_entry[0] + 1; > > > > > > buffer_end = buffer_entry + buffer_size; > > > > Before return adds correct cleanup part and code will be same as my > > original patch. > > > > So if more people think that your code is cleaner I'm OK with replacing > > it. > > Both solutions are fine and I realize I'm a bit late to the party as you > posted the original patch almost 3 weeks ago, so I don't want to delay > it any longer. I think it's just a matter of deciding whether to > enforce the buffer size limit using buffer_size or buffer_end. As the > first option involves a little bit less writing, I thought I'd suggest > it. > > > > One more minor nit: you should probably decide between "first" and > > > "one" as the phrase "only first one event" (found both in the commit > > > message and in the code comment) sounds incorrect to me. > > > > Feel free to correct commit message, I'm not very good in english... > > > > It should mean something like this... in buffer received by bios can be > > more events. That while loop iterate over events. And this my patch on > > machines with wmi version 0 will process only *one* event. And that > > event is *first* in buffer. > > Don't worry, I understood your intentions from the commit message, so I > don't think it's worth posting a v3 only to correct minor stylistic > errors. > > -- > Best regards, > Michał Kępień I've cleaned up that bit. -- Darren Hart Intel Open Source Technology Center