From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754891AbcAOTuJ (ORCPT ); Fri, 15 Jan 2016 14:50:09 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:32847 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbcAOTuG (ORCPT ); Fri, 15 Jan 2016 14:50:06 -0500 Date: Fri, 15 Jan 2016 14:50:03 -0500 (EST) Message-Id: <20160115.145003.183831730517733849.davem@davemloft.net> To: sjoerd.simons@collabora.co.uk Cc: netdev@vger.kernel.org, andrew@lunn.ch, linux-kernel@vger.kernel.org, f.fainelli@gmail.com Subject: Re: [PATCH] net: phy: turn carrier off on phy attach From: David Miller In-Reply-To: <1452805038-27178-1-git-send-email-sjoerd.simons@collabora.co.uk> References: <1452805038-27178-1-git-send-email-sjoerd.simons@collabora.co.uk> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Jan 2016 11:50:06 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sjoerd Simons Date: Thu, 14 Jan 2016 21:57:18 +0100 > The operstate of a networking device initially IF_OPER_UNKNOWN aka > "unknown", updated on carrier state changes (with carrier state being on > by default). This means it will stay unknown unless the carrier state > goes to off at some point, which is not the case if the phy is already > up/connected at startup. > > Explicitly turn off the carrier on phy attach, leaving the phy state > machine to turn the carrier on when it has done the initial negotiation. > > Signed-off-by: Sjoerd Simons Applied, thank you.