From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753544AbcAOCdc (ORCPT ); Thu, 14 Jan 2016 21:33:32 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34861 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577AbcAOCd3 (ORCPT ); Thu, 14 Jan 2016 21:33:29 -0500 Date: Thu, 14 Jan 2016 18:33:25 -0800 From: Nicolin Chen To: Timur Tabi Cc: Caleb Crome , Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options Message-ID: <20160115023325.GA29132@Asurada-Nvidia> References: <1452788982-11583-1-git-send-email-caleb@crome.org> <20160114201858.GA17567@Asurada-Nvidia> <56984BE7.2050303@tabi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56984BE7.2050303@tabi.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2016 at 07:31:19PM -0600, Timur Tabi wrote: > Nicolin Chen wrote: > >I think DT maintainers may not give a consent towards these two > >properties as they are not to describe the hardware but to hack > >software configurations. (And it seems you haven't CCed them.) > I admit it's a grey area, but the hardware doesn't work if you use > the wrong value, and it is a fixed value per device. A p1022ds > would use a different value than in in i.MX6, and once you pick a > value, it's the same no matter which sample rate, buffer size, etc > you choose. Wish we could settle down a common solution for each case. If that doesn't work for PPC, we may confine the modifications to i.MX only by overriding those settings in the fsl_ssi_imx_probe() for safety.