From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093AbcAOKaO (ORCPT ); Fri, 15 Jan 2016 05:30:14 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:17100 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756742AbcAOKaL (ORCPT ); Fri, 15 Jan 2016 05:30:11 -0500 Date: Fri, 15 Jan 2016 13:29:47 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: netdev@vger.kernel.org, Claudiu Manoil , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() Message-ID: <20160115102947.GI4764@mwanda> References: <566ABCD9.1060404@users.sourceforge.net> <56866E7F.8080609@users.sourceforge.net> <5698C53C.8060204@users.sourceforge.net> <5698C61A.90504@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5698C61A.90504@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 11:12:42AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 15 Jan 2016 10:40:24 +0100 > > Omit explicit initialisation at the beginning for four local variables > which are redefined before their first use. > > Signed-off-by: Markus Elfring > --- > drivers/net/ethernet/freescale/gianfar_ethtool.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c > index 825b051..8302f7d 100644 > --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c > +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c > @@ -768,12 +768,12 @@ static void ethflow_to_filer_rules (struct gfar_private *priv, u64 ethflow) > static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, > u64 class) > { > - unsigned int last_rule_idx = priv->cur_filer_idx; > + unsigned int last_rule_idx; This is a write only variable. We can just remove it. regards, dan carpenter