From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755167AbcAOTFk (ORCPT ); Fri, 15 Jan 2016 14:05:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51143 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbcAOTFg (ORCPT ); Fri, 15 Jan 2016 14:05:36 -0500 Date: Fri, 15 Jan 2016 17:05:32 -0200 From: Marcelo Ricardo Leitner To: Geert Uytterhoeven Cc: Vlad Yasevich , Neil Horman , "David S. Miller" , Xin Long , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sctp: Move sequence start handling into sctp_transport_get_idx() Message-ID: <20160115190532.GH6074@mrl.redhat.com> References: <1452865471-32509-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1452865471-32509-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 02:44:31PM +0100, Geert Uytterhoeven wrote: > net/sctp/proc.c: In function ‘sctp_transport_get_idx’: > net/sctp/proc.c:313: warning: ‘obj’ may be used uninitialized in this function > > This is currently a false positive, as all callers check for a zero > offset first, and handle this case in the exact same way. > > Move the check and handling into sctp_transport_get_idx() to kill the > compiler warning, and avoid future bugs. > > Signed-off-by: Geert Uytterhoeven > --- > Compile-tested only. Acked-by: Marcelo Ricardo Leitner