From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751381AbcAPJKJ (ORCPT <rfc822;w@1wt.eu>);
	Sat, 16 Jan 2016 04:10:09 -0500
Received: from mx2.suse.de ([195.135.220.15]:37187 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750993AbcAPJJ7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 16 Jan 2016 04:09:59 -0500
Date: Sat, 16 Jan 2016 10:09:38 +0100
From: Borislav Petkov <bp@suse.de>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
        "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
        Juergen Gross <jgross@suse.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>, Rusty Russell <rusty@rustcorp.com.au>,
        Jeremy Fitzhardinge <jeremy@goop.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Unifying x86_64 / Xen init paths and reading hardware_subarch
 early
Message-ID: <20160116090938.GA32085@pd.tnic>
References: <CAB=NE6VTCRCazcNpCdJ7pN1eD3=x_fcGOdH37MzVpxkKEN5esw@mail.gmail.com>
 <CALCETrXX0R-H0pTrc4eMPFb2U+N9QhEmJUmQH9-wv0k2HSStXA@mail.gmail.com>
 <20160116004304.GS11277@wotan.suse.de>
 <CAB=NE6XR2_waHnAfea+9tgWmkNQgjBBRXXDJdRzmz_=M17xZUA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAB=NE6XR2_waHnAfea+9tgWmkNQgjBBRXXDJdRzmz_=M17xZUA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 15, 2016 at 05:39:05PM -0800, Luis R. Rodriguez wrote:
> On Fri, Jan 15, 2016 at 4:43 PM, Luis R. Rodriguez <mcgrof@suse.com> wrote:
> >>     for (i = 0; i < sizeof(boot_params); i += 4096)
> >>         early_make_pgtable((unsigned long)params + i);
> >
> >  I'll give this a shot.
> 
> Thanks again for this! It seems to let this boot now! But it does not
> seem to provided the right value. If I use the qemu debug patch as I
> listed before to set this to 5 for kvm, and boot it doesn't come up.
> This can be tested with the qemu debug patch + this debug kernel patch
> which prints it out and resets it from what it finds early.
> 
> If you comment out the boot_params.hdr.hardware_subarch =
> my_hardware_subarch; assignment we get the right value from the
> copy_bootdata() work. I use my_hardware_subarch just as a quick hack
> to test and cache the value early code gets but that I can't print
> early on.

You can always do stupid debug loops:

	while (subarch == <expected_value>)
		rep_nop();

and when your guest stops booting and gdb points you here, then you know
what's going on. You can then dump interesting stuff too from gdb.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--