From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbcAPXCf (ORCPT ); Sat, 16 Jan 2016 18:02:35 -0500 Received: from wp260.webpack.hosteurope.de ([80.237.133.29]:51499 "EHLO wp260.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434AbcAPXCd (ORCPT ); Sat, 16 Jan 2016 18:02:33 -0500 Date: Sun, 17 Jan 2016 00:02:26 +0100 From: Luis Ressel To: keyrings@vger.kernel.org Cc: linux-kernel@vger.kernel.org, David Howells , David Woodhouse , James Morris Subject: Re: [PATCH] Restrict read access to private module signing key Message-ID: <20160117000226.493fa99f@gentp.lnet> In-Reply-To: <1451747630-15940-1-git-send-email-aranea@aixah.de> References: <1451747630-15940-1-git-send-email-aranea@aixah.de> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;aranea@aixah.de;1452985353;bd718cfe; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2 Jan 2016 16:13:50 +0100 Luis Ressel wrote: > The autogenerated module signing key shouldn't be world-readable. > > Signed-off-by: Luis Ressel > --- > certs/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/certs/Makefile b/certs/Makefile > index 28ac694..7f1f082 100644 > --- a/certs/Makefile > +++ b/certs/Makefile > @@ -49,6 +49,8 @@ $(obj)/signing_key.pem: $(obj)/x509.genkey > @echo "### needs to be run as root, and uses a hardware > random" @echo "### number generator if one is available." > @echo "###" > + touch $(obj)/signing_key.pem > + chmod 0600 $(obj)/signing_key.pem > openssl req -new -nodes -utf8 -$(CONFIG_MODULE_SIG_HASH) > -days 36500 \ -batch -x509 -config $(obj)/x509.genkey \ > -outform PEM -out $(obj)/signing_key.pem \ I've contributed this patch two weeks ago, but there hasn't been any feedback and it hasn't been merged, either. It's the first kernel patch I've submitted, so I don't know much about the procedures here. Could someone please merge the patch or point out any problems with it? Regards, Luis Ressel