From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbcAQAN1 (ORCPT ); Sat, 16 Jan 2016 19:13:27 -0500 Received: from mail.kernel.org ([198.145.29.136]:40297 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbcAQANZ (ORCPT ); Sat, 16 Jan 2016 19:13:25 -0500 Date: Sat, 16 Jan 2016 18:13:21 -0600 From: Rob Herring To: Duc Dang Cc: Jassi Brar , Paul Bolle , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@apm.com, Feng Kan Subject: Re: [PATCH v4 2/3] Documentation: mailbox: Add APM X-Gene SLIMpro mailbox dts documentation Message-ID: <20160117001321.GA7791@rob-hp-laptop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 06:57:18PM -0800, Duc Dang wrote: > This adds the APM X-Gene SLIMpro mailbox device tree > node documentation. > > Signed-off-by: Feng Kan > Signed-off-by: Duc Dang > --- > Changes since v3: > - Rebase over v4.4 > - Change number of mailbox IRQs to 8 > - Fix white spaces, typos. > > .../bindings/mailbox/xgene-slimpro-mailbox.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/xgene-slimpro-mailbox.txt > > diff --git a/Documentation/devicetree/bindings/mailbox/xgene-slimpro-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xgene-slimpro-mailbox.txt > new file mode 100644 > index 0000000..91774d7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/xgene-slimpro-mailbox.txt > @@ -0,0 +1,35 @@ > +The APM X-Gene SLIMpro mailbox is used to communicate messages between > +the ARM64 processors and the Cortex M3 (dubbed SLIMpro). It uses a simple > +interrupt based door bell mechanism and can exchange simple messages using the > +internal registers. > + > +There are total of 7 interrupts in this mailbox. Each used for an individual > +door bell (or mailbox channel). > + > +Required properties: > +- compatible: Should be as "apm,xgene-slimpro-mbox". > + > +- reg: Contains the mailbox register address range. > + > +- interrupts: 8 interrupts must be from 0 to 7, interrupt 0 define the > + the interrupt for mailbox channel 0 and interrupt 1 for > + mailbox channel 1 and so likewise for the reminder. > + > +- #mbox-cells: only one to specify the mailbox channel number. > + > +Example: > + > +Mailbox Node: > + slimpro-mbox: slimpro-mbox@10540000 { Nit: just use mailbox@ or mbox@ (whatever others are using) for node name. Otherwise: Acked-by: Rob Herring