From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752274AbcAQMpd (ORCPT <rfc822;w@1wt.eu>);
	Sun, 17 Jan 2016 07:45:33 -0500
Received: from mail-lb0-f171.google.com ([209.85.217.171]:33733 "EHLO
	mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751149AbcAQMpc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 17 Jan 2016 07:45:32 -0500
Date: Sun, 17 Jan 2016 18:41:58 +0600
From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Borislav Petkov <bp@suse.de>
Cc: Alexander Kuleshov <kuleshovmail@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Wang Nan <wangnan0@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/traps: rename conditional_{sti,cli} to
 cond_local_irq_{enable,disable}
Message-ID: <20160117124158.GA1092@localhost>
References: <1453013621-19358-1-git-send-email-kuleshovmail@gmail.com>
 <20160117093543.GA8549@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160117093543.GA8549@pd.tnic>
X-Operating-System: Linux
X-Date: Sun Jan 17 18:17:01 ALMT 2016
User-Agent: Mutt/1.6.0-rc0 ((null))
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01-17-16, Borislav Petkov wrote:
> On Sun, Jan 17, 2016 at 12:53:41PM +0600, Alexander Kuleshov wrote:
> So I gave you the example with preempt_enable_no_resched() but you have
> sched_preempt_enable_no_resched() below. Why?
> 
> Does the traps.c code look like scheduler code and there you have to use
> scheduler primitives? Or was there another reason for it I'm not seeing
> right now?

Sorry, no, you are right here. Seems that put wrong version during reading
of linux/preempt.h.

> Also, for your next submission, always try to answer to the question
> "Why is the change being done" in the commit message instead of
> explaining what you're doing. Because "what you're doing" we can see,
> *why* you're doing it is the much more interesting question.
> 

Agree. Especially for *git blame*.

> For example, I would've written:
> 
> "Make the preemption and interrupt flag handling more readable in the
> traps.c code. While at it, remove silly helpers and rename others to
> more understandable names so that one doesn't have to go and lookup the
> function definition when looking at the code flow."
> 
> Or something with a similar effect...

Thank you Borislav for help. I will update commit message and
s/sched_preempt_enable_no_resched/preempt_enable_no_resched in the patch,
and resend it.