RE: [PATCH V3 0/2] AMD NTB V3 changes

Allen Hubbe
2016-01-14T15:55:46Z

> From: Xiangliang Yu <Xiangliang.Yu@amd.com>
>
> Main changes in V3
> 1. Remove all power managment related code.

Can you send the third patch with the power management code? I think it is important functionality.

Furthermore, a review of the power management patch will help with getting the flush patch accepted. If the power management patch is reviewed and acked as is, the flush patch is probably ok, too, as is. If there are changes to power management that are also applicable to the flush patch, it would be good to keep it all consistent when adding the functionality to the api.

> 2. Put makefile and kconfig changes in first patch.
> 3. Call readl/writel directly, not use macros to hide it.

I think this is almost ready. See comments in NTB: Add AMD PCI-Express NTB driver.

Allen