Re: [PATCH V3 0/2] AMD NTB V3 changes

Jon Mason
2016-01-18T04:10:55Z

On Fri, Jan 15, 2016 at 12:12:24PM -0500, Allen Hubbe wrote:
> > From: Yu, Xiangliang <Xiangliang.Yu@amd.com>
>
> > I want to add flush function into ntb_transport.c, but I can't verify
> > the implementation
>
> Ok. That's a good reason to hold back the flush mechanism: it's not been tested.
>
> Nak (for now): [PATCH V3 2/2] NTB: Add support for flush request interface
>
> Don't give up. Please keep working on this, and the power management patch, to get them reviewed and accepted. It's your choice whether or not to submit the patches, and when. I'd encourage you to do it early, rather than delay.

I'd like to echo Allen's comment above. Do not give up. This code is
very close to being accepted (once the issues that Allen and I pointed
out are addressed). If you can get us another version on/before
Wednesday, it should make the 4.5 release (assuming it is acceptable
and the wdinow is not closed prematurely).

Thanks for all of your hard work (and many thanks to Allen for his
reviews of the code as well).
- Jon

>
> Allen
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/000001d14fb7%24e7981bd0%24b6c85370%24%40emc.com.
> For more options, visit https://groups.google.com/d/optout.