From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550AbcARKK3 (ORCPT ); Mon, 18 Jan 2016 05:10:29 -0500 Received: from mail.skyhub.de ([78.46.96.112]:48207 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006AbcARKK0 (ORCPT ); Mon, 18 Jan 2016 05:10:26 -0500 Date: Mon, 18 Jan 2016 11:10:04 +0100 From: Borislav Petkov To: tim.gardner@canonical.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4.4-rc8 1/4] x86/microcode/intel: save_mc_for_early: Squelch frame size warning Message-ID: <20160118101004.GC12644@pd.tnic> References: <1452178799-20878-1-git-send-email-tim.gardner@canonical.com> <1452178799-20878-2-git-send-email-tim.gardner@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1452178799-20878-2-git-send-email-tim.gardner@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 07:59:56AM -0700, tim.gardner@canonical.com wrote: > From: Tim Gardner > > arch/x86/kernel/cpu/microcode/intel.c: In function 'save_mc_for_early': > arch/x86/kernel/cpu/microcode/intel.c:516:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] Ok, so this looks like a 32-bit warning to me. Hmm, so, on the one hand we do have: $ git grep CONFIG_FRAME_WARN arch/x86/ arch/x86/configs/i386_defconfig:291:CONFIG_FRAME_WARN=2048 which came in with: 5cb04df8d3f0 ("x86: defconfig updates") and OTOH: config FRAME_WARN int "Warn for stack frames larger than (needs gcc 4.4)" range 0 8192 default 0 if KASAN default 1024 if !64BIT ^^^^ default 2048 if 64BIT help Tell gcc to warn at build time for stack frames larger than this. Setting this too low will cause a lot of warnings. Setting it to 0 disables the warning. Requires gcc 4.4 which is still 1024. tip guys, maybe it is time to update lib/Kconfig.debug too? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.