From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755370AbcAROHS (ORCPT ); Mon, 18 Jan 2016 09:07:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:58389 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755126AbcAROHN (ORCPT ); Mon, 18 Jan 2016 09:07:13 -0500 Date: Mon, 18 Jan 2016 15:06:49 +0100 From: Borislav Petkov To: Thomas Voegtle Cc: Michal Marek , =?utf-8?B?TcOlbnMgUnVsbGfDpXJk?= , Markus Trippelsdorf , linux-kernel@vger.kernel.org, x86-ml Subject: Re: [RFC PATCH] x86/kconfig: Sanity-check config file during oldconfig Message-ID: <20160118140649.GC12651@pd.tnic> References: <568FB028.1030706@suse.cz> <20160108133725.GH14673@pd.tnic> <568FCC45.1010301@suse.cz> <20160111194311.GF4686@pd.tnic> <20160111205945.GH4686@pd.tnic> <20160111211712.GI4686@pd.tnic> <20160114184350.GB12109@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2016 at 02:36:09PM +0100, Thomas Voegtle wrote: > My problem was, CONFIG_MICROCODE got dropped silently, and yes that is > fixed for me with this patch. But I think this is a little bit odd way > to fix it, but I don't have a better idea. Me neither. The problem is, I need to grep the config that goes into the "oldconfig" *before* scripts/kconfig/conf gets a hold of it and satisfies deps and thus turns off CONFIG_MICROCODE in the process. This is a simpler solution short of hacking scripts/kconfig/conf and it can be used for other stuff we might need in arch/x86/ > What's with olddefconfig Yes, I'll update the patch. > and silentoldconfig ? This one is funny. Makefile's help says: silentoldconfig - Same as oldconfig, but quietly, additionally update deps and yet doing $ make silentoldconfig is not very silent and goes through all new prompts asking me about them. Regarding this issue, yes, I'll add its name to the script too. > btw that patch has to go to stable 4.4, too Sure, once we agree on the approach. Thanks. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --