public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Diego Viola <diego.viola@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] README: cosmetic fixes
Date: Mon, 18 Jan 2016 15:40:35 -0700	[thread overview]
Message-ID: <20160118154035.31455402@lwn.net> (raw)
In-Reply-To: <CA+ToGPFL5bC2GSir9O2A+bF51wfDJoAh4NCex=OGH2cmxwEm5g@mail.gmail.com>

On Mon, 18 Jan 2016 17:53:02 -0200
Diego Viola <diego.viola@gmail.com> wrote:

> The thing I'm unsure about is that the pull request contained trivial
> changes from others as well, and my patch was trivial, yes.
> 
> So why not include my changes with the other trivial changes as well?

I set aside when I raised my initial complaint, and it stayed set aside.

I'll consider it again, but I'm not very enthusiastic about applying
stylistic fixes.  We really don't need trivial patch wars over how many
exclamation points belong on a given sentence.

Diego, I'd like to ask you to sit back a bit and think about what you are
really trying to accomplish.  Maintainers are busy people, and you place a
demand on their time whenever you post a patch.  That time is available in
*very* limited quantities for patches that don't really make the kernel
better.  Please think a bit about why you're doing this, and how you might
direct your energy toward creating changes that maintainers actively want
to apply.  That will leave everybody better off than nagging people about
cosmetic changes.

Thanks,

jon

  reply	other threads:[~2016-01-18 22:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05 19:50 [PATCH] README: cosmetic fixes Diego Viola
2015-12-10 18:34 ` Jonathan Corbet
2015-12-11  3:06   ` Diego Viola
2016-01-17 22:54   ` Diego Viola
2016-01-18  9:44     ` Jiri Kosina
2016-01-18 13:41       ` Diego Viola
2016-01-18 19:53       ` Diego Viola
2016-01-18 22:40         ` Jonathan Corbet [this message]
2016-01-19  1:32           ` Diego Viola
2016-01-19  2:40             ` Diego Viola
2016-01-19  6:24               ` Diego Viola
2016-01-25 19:40 ` Jonathan Corbet
2016-01-28 18:23   ` Diego Viola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160118154035.31455402@lwn.net \
    --to=corbet@lwn.net \
    --cc=diego.viola@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox