From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756232AbcARScN (ORCPT ); Mon, 18 Jan 2016 13:32:13 -0500 Received: from casper.infradead.org ([85.118.1.10]:37964 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755408AbcARScI (ORCPT ); Mon, 18 Jan 2016 13:32:08 -0500 Date: Mon, 18 Jan 2016 19:32:05 +0100 From: Peter Zijlstra To: Christian Borntraeger Cc: Tejun Heo , "linux-kernel@vger.kernel.org >> Linux Kernel Mailing List" , linux-s390 , KVM list , Oleg Nesterov , "Paul E. McKenney" Subject: Re: regression 4.4: deadlock in with cgroup percpu_rwsem Message-ID: <20160118183205.GW6357@twins.programming.kicks-ass.net> References: <56978452.6010606@de.ibm.com> <20160114195630.GA3520@mtj.duckdns.org> <5698A023.9070703@de.ibm.com> <56990C9E.7020801@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56990C9E.7020801@de.ibm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 04:13:34PM +0100, Christian Borntraeger wrote: > > Yes, the deadlock is gone and the system is still running. > > After some time I had the following WARN in the logs, though. > > Not sure yet if that is related. > > > > [25331.763607] DEBUG_LOCKS_WARN_ON(lock->owner != current) > > [25331.763630] ------------[ cut here ]------------ > > [25331.763634] WARNING: at kernel/locking/mutex-debug.c:80 > I restarted the test with panic_on_warn. Hopefully I can get a dump to check > which mutex this was. Hard to reproduce warnings like this tend to point towards memory corruption. Someone stepped on the mutex value and tickles the sanity check. With lockdep and debugging enabled the mutex gets quite a bit bigger, so it gets more likely to be hit by 'random' corruption. The locking in seq_read() seems rather straight forward.