From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755340AbcARO33 (ORCPT ); Mon, 18 Jan 2016 09:29:29 -0500 Received: from mail.lzu.cn ([202.201.0.205]:58012 "EHLO lzu.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755267AbcARO3B convert rfc822-to-8bit (ORCPT ); Mon, 18 Jan 2016 09:29:01 -0500 Date: Mon, 18 Jan 2016 21:29:35 +0800 From: Wang Xiaoqiang To: Ingo Molnar Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: [PATCH] perf/core: Directly return the error pointer instead of use 'goto' Message-ID: <20160118212935.69417deb@debian> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT X-CM-TRANSID: zQDJygAnL2OR9pxWEGlOAA--.46981S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cr4rArW5uFyDZr4DWry8Krg_yoW8GF4fpr srAasxtayrAw12v3y5C3WkZ34UXw48XFZ8G3WkJ3yIyrn0qws5WF1qgr15Zr1aqFWIyayU tw1jgryYv34UuFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Cb7Iv0xC_Zr1lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2vYz4IE04k24VAvwVAKI4IrM2AIxVAIcxkEcVAq07x2 0xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18Mc Ij6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l F7xvr2IYc2Ij64vIr40E4x8a64kEw24lc2xSY4AK67AK6ry5MxAIw28IcxkI7VAKI48JMx C20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAF wI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20x vE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v2 0xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14 v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jIHq7UUUUU= X-CM-SenderInfo: pzdqw5btrqqzl2xovvfxof0/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ingo, This patch return the error pointer directly, not use 'goto'. Patch is as follows. thanks, Wang Xiaoqiang >>From 33ed914e6d3f3d63698b5e178efd648ca7cd086d Mon Sep 17 00:00:00 2001 From: Wang Xiaoqiang Date: Mon, 18 Jan 2016 21:14:06 +0800 Subject: [PATCH] perf/core: Directly return the error pointer instead of use 'goto' Just return the error pointer instead of using "goto" to make the program structure more clear. Signed-off-by: Wang Xiaoqiang --- kernel/events/core.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index bf82441..1d250b2 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8550,10 +8550,8 @@ perf_event_create_kernel_counter(struct perf_event_attr *attr, int cpu, event = perf_event_alloc(attr, cpu, task, NULL, NULL, overflow_handler, context, -1); - if (IS_ERR(event)) { - err = PTR_ERR(event); - goto err; - } + if (IS_ERR(event)) + return event; /* Mark owner so we could distinguish it from user events. */ event->owner = EVENT_OWNER_KERNEL; @@ -8584,7 +8582,7 @@ perf_event_create_kernel_counter(struct perf_event_attr *attr, int cpu, err_free: free_event(event); -err: + return ERR_PTR(err); } EXPORT_SYMBOL_GPL(perf_event_create_kernel_counter); -- 2.1.4