From: "Pali Rohár" <pali.rohar@gmail.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Andy Lutomirski <luto@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes
Date: Tue, 19 Jan 2016 10:07:36 +0100 [thread overview]
Message-ID: <20160119090736.GF7192@pali> (raw)
In-Reply-To: <20160119100303.73cf6256@endymion.delvare>
On Tuesday 19 January 2016 10:03:03 Jean Delvare wrote:
> Hi Pali,
>
> On Tue, 19 Jan 2016 09:36:33 +0100, Pali Rohár wrote:
> > On Tuesday 19 January 2016 08:54:26 Jean Delvare wrote:
> > > > @@ -978,11 +978,11 @@ int dmi_walk(void (*decode)(const struct dmi_header *, void *),
> > > > u8 *buf;
> > > >
> > > > if (!dmi_available)
> > > > - return -1;
> > > > + return -ENOENT;
> > >
> > > -ENOSYS would seem more appropriate?
> >
> > IIRC -ENOSYS is for non implemented syscalls.
>
> I can see a lot of -ENOSYS in include/linux/*.h returned by stubs when
> a specific subsystem is not included. Not related to syscalls at all.
> This is what lead to my suggestion.
https://lkml.org/lkml/2014/8/22/492
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-01-19 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 20:59 [PATCH v2 0/3] dell-wmi: DMI misuse fixes Andy Lutomirski
2016-01-18 20:59 ` [PATCH v2 1/3] dell-wmi: Stop storing pointers to DMI tables Andy Lutomirski
2016-01-19 8:41 ` Jean Delvare
2016-01-19 11:04 ` Jean Delvare
2016-01-19 18:28 ` Andy Lutomirski
2016-01-18 20:59 ` [PATCH v2 2/3] dell-wmi: Fix hotkey table size check Andy Lutomirski
2016-01-19 8:31 ` Jean Delvare
2016-01-19 18:42 ` Andy Lutomirski
2016-01-18 20:59 ` [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Andy Lutomirski
2016-01-19 7:54 ` Jean Delvare
2016-01-19 8:36 ` Pali Rohár
2016-01-19 9:03 ` Jean Delvare
2016-01-19 9:07 ` Pali Rohár [this message]
2016-01-19 9:40 ` Jean Delvare
2016-01-19 23:51 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119090736.GF7192@pali \
--to=pali.rohar@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).