From: Johan Hovold <johan@kernel.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/10] tty: Fix tty_init_termios() declaration
Date: Tue, 19 Jan 2016 10:17:02 +0100 [thread overview]
Message-ID: <20160119091702.GA28220@localhost> (raw)
In-Reply-To: <1452402833-8652-6-git-send-email-peter@hurleysoftware.com>
On Sat, Jan 09, 2016 at 09:13:48PM -0800, Peter Hurley wrote:
> tty_init_termios() never returns an error; re-declare as void. Remove
> unnecessary error handling from callers. Remove extern declarations
> of tty_free_termios() and free_tty_struct() and re-declare in file
> scope.
>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
> drivers/tty/pty.c | 15 +++------------
> drivers/tty/tty_io.c | 13 ++++---------
> drivers/usb/serial/console.c | 6 +-----
For the usb-serial bits
Acked-by: Johan Hovold <johan@kernel.org>
Thanks,
Johan
next prev parent reply other threads:[~2016-01-19 9:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 2:25 [PATCH 00/12] Rework tty_reopen() Peter Hurley
2015-11-28 2:25 ` [PATCH 01/12] tty: Fix ldisc leak in failed tty_init_dev() Peter Hurley
2015-11-28 2:25 ` [PATCH 02/12] tty: Remove !tty check from free_tty_struct() Peter Hurley
2015-11-28 2:25 ` [PATCH 03/12] tty: Fix tty_init_termios() declaration Peter Hurley
2015-11-28 2:25 ` [PATCH 04/12] tty: Re-declare tty_driver_remove_tty() file scope Peter Hurley
2015-11-28 2:25 ` [PATCH 05/12] pty: Remove pty_unix98_shutdown() Peter Hurley
2015-11-28 2:25 ` [PATCH 06/12] tty: Remove __lockfunc annotation from tty lock functions Peter Hurley
2015-11-28 2:25 ` [PATCH 07/12] tty: Wait interruptibly for tty lock on reopen Peter Hurley
2015-11-28 2:25 ` [PATCH 08/12] pty: Prepare to redefine tty driver remove() interface Peter Hurley
2015-11-28 2:25 ` [PATCH 09/12] tty: Re-define " Peter Hurley
2015-11-28 2:25 ` [PATCH 10/12] tty: Consolidate noctty checks in tty_open() Peter Hurley
2015-11-28 2:25 ` [PATCH 11/12] tty: Refactor tty_open() Peter Hurley
2015-11-28 2:25 ` [PATCH 12/12] tty: Retry failed reopen if tty teardown in-progress Peter Hurley
2015-12-16 15:43 ` [PATCH 00/12] Rework tty_reopen() Peter Hurley
2015-12-17 5:53 ` Pratyush Anand
2015-12-17 7:15 ` Greg Kroah-Hartman
2016-01-10 5:13 ` [PATCH v2 00/10] " Peter Hurley
2016-01-10 5:13 ` [PATCH v2 01/10] tty: Wait interruptibly for tty lock on reopen Peter Hurley
2016-01-10 5:13 ` [PATCH v2 02/10] tty: Retry failed reopen if tty teardown in-progress Peter Hurley
2016-01-10 5:13 ` [PATCH v2 03/10] tty: Fix ldisc leak in failed tty_init_dev() Peter Hurley
2016-01-10 5:13 ` [PATCH v2 04/10] tty: Remove !tty check from free_tty_struct() Peter Hurley
2016-01-10 5:13 ` [PATCH v2 05/10] tty: Fix tty_init_termios() declaration Peter Hurley
2016-01-19 9:17 ` Johan Hovold [this message]
2016-01-10 5:13 ` [PATCH v2 06/10] tty: Re-declare tty_driver_remove_tty() file scope Peter Hurley
2016-01-10 5:13 ` [PATCH v2 07/10] pty: Remove pty_unix98_shutdown() Peter Hurley
2016-01-10 5:13 ` [PATCH v2 08/10] tty: Remove __lockfunc annotation from tty lock functions Peter Hurley
2016-01-10 5:13 ` [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open() Peter Hurley
2016-03-26 17:58 ` Richard Weinberger
2016-03-26 19:06 ` Peter Hurley
2016-03-26 19:14 ` Richard Weinberger
2016-01-10 5:13 ` [PATCH v2 10/10] tty: Refactor tty_open() Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119091702.GA28220@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox