From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932781AbcASJRP (ORCPT ); Tue, 19 Jan 2016 04:17:15 -0500 Received: from mail-lb0-f194.google.com ([209.85.217.194]:32824 "EHLO mail-lb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932767AbcASJRE (ORCPT ); Tue, 19 Jan 2016 04:17:04 -0500 Date: Tue, 19 Jan 2016 10:17:02 +0100 From: Johan Hovold To: Peter Hurley Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/10] tty: Fix tty_init_termios() declaration Message-ID: <20160119091702.GA28220@localhost> References: <1448677557-16420-1-git-send-email-peter@hurleysoftware.com> <1452402833-8652-1-git-send-email-peter@hurleysoftware.com> <1452402833-8652-6-git-send-email-peter@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452402833-8652-6-git-send-email-peter@hurleysoftware.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 09, 2016 at 09:13:48PM -0800, Peter Hurley wrote: > tty_init_termios() never returns an error; re-declare as void. Remove > unnecessary error handling from callers. Remove extern declarations > of tty_free_termios() and free_tty_struct() and re-declare in file > scope. > > Signed-off-by: Peter Hurley > --- > drivers/tty/pty.c | 15 +++------------ > drivers/tty/tty_io.c | 13 ++++--------- > drivers/usb/serial/console.c | 6 +----- For the usb-serial bits Acked-by: Johan Hovold Thanks, Johan