From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932747AbcASSBz (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jan 2016 13:01:55 -0500
Received: from mga11.intel.com ([192.55.52.93]:22484 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932414AbcASSBu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jan 2016 13:01:50 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,318,1449561600"; 
   d="scan'208";a="893990173"
Date: Tue, 19 Jan 2016 10:00:27 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, John Stultz <john.stultz@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <len.brown@intel.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>, Paul Turner <pjt@google.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 3/4] sched: introduce synchronized idle injection
Message-ID: <20160119100027.3e341530@icelake>
In-Reply-To: <20160119120605.GA26634@gmail.com>
References: <20151118154457.GD30184@e105550-lin.cambridge.arm.com>
	<564C9E93.8030901@linux.intel.com>
	<20151119172405.GA798@e105550-lin.cambridge.arm.com>
	<20151119200906.GS3816@twins.programming.kicks-ass.net>
	<alpine.DEB.2.11.1511201032300.3989@nanos>
	<20151120102014.GC17308@twins.programming.kicks-ass.net>
	<alpine.DEB.2.11.1511201150480.3989@nanos>
	<20151120125441.GD17308@twins.programming.kicks-ass.net>
	<alpine.DEB.2.11.1511201418580.3989@nanos>
	<20160111135005.49f38a45@icelake>
	<20160119120605.GA26634@gmail.com>
Organization: OTC
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 19 Jan 2016 13:06:05 +0100
Ingo Molnar <mingo@kernel.org> wrote:

> > If we just look at 20% forced idle, I can see significantly more
> > deep package C-states(PC7) residency.
> > 		Pkg%pc2 	Pkg%pc6 	Pkg%pc7 
> > w/o patch	3.17		4.39   		13.21 
> > w/ patch	1.15   		1.43            17.24   
> 
> Can this be translated to: "this patch improved power efficiency
> (watts per second) by XYZ percent?", with XYZ filled in accordingly?

With CPU bound workload and 20% idle injection ratio, this patch
improves performance per watt by 3.2% on Ivy Bridge system with
Package C7 as the deepest idle.

The above packages C-state residency explains why, i.e. more deeper PC7
when tick is stopped.

With newer CPUs, this improvements should be more visible in that
low power package C-states are getting deeper/less power. I will test
on Skylake client as soon as I have time.

Thanks,

Jacob