From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932970AbcASKaw (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jan 2016 05:30:52 -0500
Received: from mail-wm0-f65.google.com ([74.125.82.65]:36507 "EHLO
	mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932830AbcASKao (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jan 2016 05:30:44 -0500
Date: Tue, 19 Jan 2016 11:30:39 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Michal Marek <mmarek@suse.cz>
Cc: Borislav Petkov <bp@suse.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>,
        Markus Trippelsdorf <markus@trippelsdorf.de>,
        Thomas Voegtle <tv@lio96.de>, linux-kernel@vger.kernel.org,
        x86-ml <x86@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>, Jiri Olsa <jolsa@redhat.com>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>
Subject: Re: [RFC] CONFIG_GENERIC_BOOTABLE_CONFIG=y
Message-ID: <20160119103038.GA5301@gmail.com>
References: <20160108133725.GH14673@pd.tnic>
 <568FCC45.1010301@suse.cz>
 <20160111194311.GF4686@pd.tnic>
 <yw1x4mejx3le.fsf@unicorn.mansr.com>
 <20160111205945.GH4686@pd.tnic>
 <yw1xziwbvnde.fsf@unicorn.mansr.com>
 <20160111211712.GI4686@pd.tnic>
 <20160114184350.GB12109@pd.tnic>
 <20160119082022.GB18237@gmail.com>
 <569E089B.2000808@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <569E089B.2000808@suse.cz>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Michal Marek <mmarek@suse.cz> wrote:

> On 2016-01-19 09:20, Ingo Molnar wrote:
> > In fact on x86 I'd suggest we go farther than that and add a core set of selects 
> > that can be disabled only through a sufficiently scary "I really know I'm doing 
> > something utmost weird" (and default disabled) config option.
> 
> Agreed.
> 
> 
> > From my own randconfig testing I can give a core list of must-have kernel options, 
> > without which most distros (Fedora, RHEL, Ubuntu, SuSE) won't boot properly:
> > 
> > +config FORCE_MINIMALLY_SANE_CONFIG
> > +	bool
> > +	default y
> 
> You should add a prompt so that the option can be disabled. Or make it
> default !EXPERT, to have a single "I know what I'm doing"-type of option.

Yeah, it sure should be interactive. This was pasted from my automated testing 
that isn't interested in unbootable kernels.

So it should be something like:

	config GENERIC_BOOTABLE_CONFIG
	bool "Enable kernel options that are needed to boot typical Linux distributions"
	default y
	...

(I removed the 'SANE' naming as disabling this option is obviously not 'insane'.)

Thanks,

	Ingo