From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754399AbcASNJJ (ORCPT ); Tue, 19 Jan 2016 08:09:09 -0500 Received: from casper.infradead.org ([85.118.1.10]:56742 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754277AbcASNJD (ORCPT ); Tue, 19 Jan 2016 08:09:03 -0500 Date: Tue, 19 Jan 2016 14:08:57 +0100 From: Peter Zijlstra To: Frederic Weisbecker Cc: LKML , Byungchul Park , Chris Metcalf , Thomas Gleixner , Luiz Capitulino , Christoph Lameter , "Paul E . McKenney" , Mike Galbraith , Rik van Riel Subject: Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick Message-ID: <20160119130857.GC6344@twins.programming.kicks-ass.net> References: <1452700891-21807-1-git-send-email-fweisbec@gmail.com> <1452700891-21807-2-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452700891-21807-2-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 05:01:28PM +0100, Frederic Weisbecker wrote: > The cpu load update on tick doesn't care about dynticks and as such is > buggy when occuring on nohz ticks (including idle ticks) as it resets > the jiffies snapshot that was recorded on nohz entry. We eventually > ignore the potentially long tickless load that happened before the > tick. I don't get it, how can we call scheduler_tick() while tick_nohz_tick_stopped() ?