From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755319AbcASN7K (ORCPT ); Tue, 19 Jan 2016 08:59:10 -0500 Received: from 8bytes.org ([81.169.241.247]:46101 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754462AbcASN7I (ORCPT ); Tue, 19 Jan 2016 08:59:08 -0500 Date: Tue, 19 Jan 2016 14:59:06 +0100 From: Joerg Roedel To: Borislav Petkov Cc: X86 ML , LKML , David Kaplan , Tom Lendacky Subject: Re: [PATCH] x86/cpufeature: Add AMD AVIC bit Message-ID: <20160119135905.GA18805@8bytes.org> References: <1452938292-12327-1-git-send-email-bp@alien8.de> <20160119123900.GZ18805@8bytes.org> <20160119134433.GE15503@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160119134433.GE15503@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 02:44:33PM +0100, Borislav Petkov wrote: > On Tue, Jan 19, 2016 at 01:39:00PM +0100, Joerg Roedel wrote: > > That is not enough, you also need to add the feature to the > > scattered cpuid_bits in arch/x86/kernel/cpu/scattered.c. The cpuid > > Fn8000_000A_EDX is not mapped 1-1 into the x86_capability array. > > 2ccd71f1b278 ("x86/cpufeature: Move some of the scattered feature bits to x86_capability") Ah I see, that commit wasn't present in the tree I looked at. In that case: Reviewed-by: Joerg Roedel