[PATCH] x86/cpufeature: Add AMD AVIC bit

[PATCH] x86/cpufeature: Add AMD AVIC bit

[Borislav Petkov]

From: Borislav Petkov <bp@suse.de>

CPUID Fn8000_000A_EDX[13] denotes support for AMD's Virtual Interrupt
controller, i.e., APIC virtualization.

Cc: David Kaplan <david.kaplan@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
---
 arch/x86/include/asm/cpufeature.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
index 7ad8c9464297..bbf166e805be 100644
--- a/arch/x86/include/asm/cpufeature.h
+++ b/arch/x86/include/asm/cpufeature.h
@@ -268,6 +268,7 @@
 #define X86_FEATURE_DECODEASSISTS (15*32+ 7) /* Decode Assists support */
 #define X86_FEATURE_PAUSEFILTER (15*32+10) /* filtered pause intercept */
 #define X86_FEATURE_PFTHRESHOLD (15*32+12) /* pause filter threshold */
+#define X86_FEATURE_AVIC	(15*32+13) /* Virtual Interrupt Controller */
 
 /*
  * BUG word(s)
-- 
2.3.5

Re: [PATCH] x86/cpufeature: Add AMD AVIC bit

[Joerg Roedel]

On Sat, Jan 16, 2016 at 10:58:12AM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> CPUID Fn8000_000A_EDX[13] denotes support for AMD's Virtual Interrupt
> controller, i.e., APIC virtualization.
> 
> Cc: David Kaplan <david.kaplan@amd.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
>  arch/x86/include/asm/cpufeature.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
> index 7ad8c9464297..bbf166e805be 100644
> --- a/arch/x86/include/asm/cpufeature.h
> +++ b/arch/x86/include/asm/cpufeature.h
> @@ -268,6 +268,7 @@
>  #define X86_FEATURE_DECODEASSISTS (15*32+ 7) /* Decode Assists support */
>  #define X86_FEATURE_PAUSEFILTER (15*32+10) /* filtered pause intercept */
>  #define X86_FEATURE_PFTHRESHOLD (15*32+12) /* pause filter threshold */
> +#define X86_FEATURE_AVIC	(15*32+13) /* Virtual Interrupt Controller */

That is not enough, you also need to add the feature to the scattered
cpuid_bits in arch/x86/kernel/cpu/scattered.c.
The cpuid Fn8000_000A_EDX is not mapped 1-1 into the x86_capability
array.


	Joerg

Re: [PATCH] x86/cpufeature: Add AMD AVIC bit

[Borislav Petkov]

On Tue, Jan 19, 2016 at 01:39:00PM +0100, Joerg Roedel wrote:
> That is not enough, you also need to add the feature to the
> scattered cpuid_bits in arch/x86/kernel/cpu/scattered.c. The cpuid
> Fn8000_000A_EDX is not mapped 1-1 into the x86_capability array.

2ccd71f1b278 ("x86/cpufeature: Move some of the scattered feature bits to x86_capability")

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Re: [PATCH] x86/cpufeature: Add AMD AVIC bit

[Joerg Roedel]

On Tue, Jan 19, 2016 at 02:44:33PM +0100, Borislav Petkov wrote:
> On Tue, Jan 19, 2016 at 01:39:00PM +0100, Joerg Roedel wrote:
> > That is not enough, you also need to add the feature to the
> > scattered cpuid_bits in arch/x86/kernel/cpu/scattered.c. The cpuid
> > Fn8000_000A_EDX is not mapped 1-1 into the x86_capability array.
> 
> 2ccd71f1b278 ("x86/cpufeature: Move some of the scattered feature bits to x86_capability")

Ah I see, that commit wasn't present in the tree I looked at. In that
case:

Reviewed-by: Joerg Roedel <jroedel@suse.de>

[tip:x86/cpu] x86/cpufeature: Add AMD AVIC bit

[tip-bot for Borislav Petkov]

Commit-ID:  a1ff5726081858a9ad98934eff7af6616c576875
Gitweb:     http://git.kernel.org/tip/a1ff5726081858a9ad98934eff7af6616c576875
Author:     Borislav Petkov <bp@suse.de>
AuthorDate: Sat, 16 Jan 2016 10:58:12 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 19 Jan 2016 08:29:28 +0100

x86/cpufeature: Add AMD AVIC bit

CPUID Fn8000_000A_EDX[13] denotes support for AMD's Virtual
Interrupt controller, i.e., APIC virtualization.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: David Kaplan <david.kaplan@amd.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Link: http://lkml.kernel.org/r/1452938292-12327-1-git-send-email-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/asm/cpufeature.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
index 7ad8c94..bbf166e 100644
--- a/arch/x86/include/asm/cpufeature.h
+++ b/arch/x86/include/asm/cpufeature.h
@@ -268,6 +268,7 @@
 #define X86_FEATURE_DECODEASSISTS (15*32+ 7) /* Decode Assists support */
 #define X86_FEATURE_PAUSEFILTER (15*32+10) /* filtered pause intercept */
 #define X86_FEATURE_PFTHRESHOLD (15*32+12) /* pause filter threshold */
+#define X86_FEATURE_AVIC	(15*32+13) /* Virtual Interrupt Controller */
 
 /*
  * BUG word(s)