From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757556AbcASTyV (ORCPT ); Tue, 19 Jan 2016 14:54:21 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:56225 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757208AbcASTyP (ORCPT ); Tue, 19 Jan 2016 14:54:15 -0500 Date: Tue, 19 Jan 2016 20:54:12 +0100 From: Pavel Machek To: Zhaoyang Huang Cc: zhaoyang.huang@spreadtrum.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, len.brown@intel.com, gregkh@linuxfoundation.org, linux-pm@vger.kernel.org Subject: Re: [RFC PATCH v1] refining the rpm_suspend function Message-ID: <20160119195412.GA8414@amd> References: <1453194858-17416-1-git-send-email-zhaoyang.huang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453194858-17416-1-git-send-email-zhaoyang.huang@spreadtrum.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > + else{ missing space. > + while (dev->power.runtime_status == > + RPM_SUSPENDING) { > + if (dev->power.irq_safe) { > + spin_unlock(&dev->power.lock); > + > + cpu_relax(); > + > + spin_lock(&dev->power.lock); > + continue; > + } > + > + /* Wait for the other suspend > + running in parallel with us. */ > + for (;;) { > + prepare_to_wait(&dev->power.wait_queue, > + &wait, TASK_UNINTERRUPTIBLE); > + if (dev->power.runtime_status > + != RPM_SUSPENDING) > + break; You really need to restructure the code so that you don't get indentation _this_ deep. > - might_sleep_if(!(rpmflags & RPM_ASYNC) && !dev->power.irq_safe); > + might_sleep_if (!(rpmflags & RPM_ASYNC) && !dev->power.irq_safe); Original was right. Function -> no space. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html