From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757359AbcASUrD (ORCPT ); Tue, 19 Jan 2016 15:47:03 -0500 Received: from down.free-electrons.com ([37.187.137.238]:52129 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753191AbcASUqz (ORCPT ); Tue, 19 Jan 2016 15:46:55 -0500 Date: Tue, 19 Jan 2016 21:46:53 +0100 From: Alexandre Belloni To: Robert Jarzmik Cc: Alessandro Zummo , Rob Herring , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: sa1100: detect rcnr overflow with dates after 2038 Message-ID: <20160119204653.GY3367@piout.net> References: <1453165031-29194-1-git-send-email-alexandre.belloni@free-electrons.com> <87si1tcol0.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87si1tcol0.fsf@belgarion.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19/01/2016 at 21:16:11 +0100, Robert Jarzmik wrote : > Alexandre Belloni writes: > > > rcnr will overflow in 2038, detect that overflow when setting the time and > > get rid of the deprecated rtc_tm_to_time() > > > > Signed-off-by: Alexandre Belloni > > That's very nice, but doesn't that limitation touch almost all drivers, and > could benefit from a global solution in rtc_set_time() ? > > What I'm thinking of is a field in rtc_device, a u64 which represents the > maximal time that can be set (or 0 if no maximum). rtc_set_time() would check > against that maximum and return -EINVAL. > > For the rtc drivers, upon registration they can modify this value to set up this > clamp. This will require to set only a value in each driver, which looks more > robust to me. > Actually, that is something I'm currently working on but it is not ready yet. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com