From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757688AbcATGsu (ORCPT ); Wed, 20 Jan 2016 01:48:50 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48309 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbcATGsm (ORCPT ); Wed, 20 Jan 2016 01:48:42 -0500 Date: Tue, 19 Jan 2016 22:48:41 -0800 From: Andrew Morton To: "Aneesh Kumar K.V" Cc: "Kirill A. Shutemov" , Dmitry Vyukov , "Kirill A. Shutemov" , Sasha Levin , jmarchan@redhat.com, Hugh Dickins , Dave Hansen , David Rientjes , Linus Torvalds , Vlastimil Babka , Mel Gorman , Ebru Akagunduz , Dan Williams , Minchan Kim , "linux-mm\@kvack.org" , LKML , syzkaller , Kostya Serebryany , Alexander Potapenko Subject: Re: mm: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in split_huge_page_to_list Message-Id: <20160119224841.8c16ea03.akpm@linux-foundation.org> In-Reply-To: <87powwvm6b.fsf@linux.vnet.ibm.com> References: <20160118133852.GC14531@node.shutemov.name> <87powwvm6b.fsf@linux.vnet.ibm.com> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jan 2016 11:15:32 +0530 "Aneesh Kumar K.V" wrote: > > > > I think this should fix the issue: > > > > From 10859758dadfa249616870f63c1636ec9857c501 Mon Sep 17 00:00:00 2001 > > From: "Kirill A. Shutemov" > > Date: Mon, 18 Jan 2016 16:28:12 +0300 > > Subject: [PATCH] thp: fix interrupt unsafe locking in split_huge_page() > > > > split_queue_lock can be taken from interrupt context in some cases, but > > I forgot to convert locking in split_huge_page() to interrupt-safe > > primitives. > > > > Let's fix this. > > Can you add the stack trace from the problem reported to the commit > message ? I have already done this.