From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933475AbcATA45 (ORCPT ); Tue, 19 Jan 2016 19:56:57 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:34680 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933011AbcATA4u (ORCPT ); Tue, 19 Jan 2016 19:56:50 -0500 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.203 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Wed, 20 Jan 2016 09:56:47 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo CC: Andi Kleen , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Wang Nan , Don Zickus , Pekka Enberg , Moinuddin Quadri Subject: Re: [RFC/PATCHSET 00/17] perf tools: Add support for hierachy view (v2) Message-ID: <20160120005647.GC18796@sejong> References: <1452960197-5323-1-git-send-email-namhyung@kernel.org> <20160117193153.GI4698@two.firstfloor.org> <20160119104506.GB1324@danjae.kornet> <20160119221204.GO4698@two.firstfloor.org> <20160119222449.GL27085@kernel.org> MIME-Version: 1.0 In-Reply-To: <20160119222449.GL27085@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB02/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/20 09:56:48, Serialize by Router on LGEKRMHUB02/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/20 09:56:48, Serialize complete at 2016/01/20 09:56:48 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 07:24:49PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 19, 2016 at 11:12:04PM +0100, Andi Kleen escreveu: > > > > Now we only need a better percent-limit that handles all > > > > leaves correctly... > > > > > > Hmm.. could you tell me where the percent-limit doesn't work > > > correctly? > > > > It doesn't work well together with call chains. > > Ok, that is the missing piece of info, lemme check... Yeah that seems > to be the case. So technically this is a callchain issue not a hist entry, right? If so, it should be fixed separately. Currently --percent-limit option works only for hist entries, and for callchain, users should use -g/--call-graph option. With hierarchy report, we might consider merging them since it provides continuous interface to callchains.. > > > It only considers the hits on the leaf function, but doesn't hide > > the individual call chains leading to that function which are below > > the limit. > > > > So if you have a lot of different cold callers you still end up > > with far too much output. Could you please be more specific? Let me try with an example.. $ perf report ... + 1.00% perf perf some_function some_function - common_caller - 0.6% caller1 + 0.4% caller1_1 + 0.2% caller1_2 + 0.3% caller2 + 0.1% caller3 In this case, do you want this? $ perf report --percent-limit 0.5 ... + 1.00% perf perf some_function some_function - common_caller - 0.6% caller1 > > > > Also would be nice to be able to set it dynamically from the UI. > > To set the mim percent? Yeah, we need to allow setting all those knobs > from the UI. > > I.e. should be like when we press '/' to set a substring filter. Yes, how about 'L' key for limit? Thanks, Namhyung