From: Torsten Duwe <duwe@lst.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Jiri Kosina <jkosina@suse.cz>,
Denis Kirjanov <kda@linux-powerpc.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org
Subject: Re: [PATCH v5 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2)
Date: Wed, 20 Jan 2016 10:07:14 +0100 [thread overview]
Message-ID: <20160120090714.GA7031@lst.de> (raw)
In-Reply-To: <1453269803.14751.10.camel@ellerman.id.au>
On Wed, Jan 20, 2016 at 05:03:23PM +1100, Michael Ellerman wrote:
> On Wed, 2016-01-06 at 15:17 +0100, Petr Mladek wrote:
> > On Fri 2015-12-04 15:45:29, Torsten Duwe wrote:
> > > Changes since v4:
> > > * change comment style in entry_64.S to C89
> > > (nobody is using assembler syntax comments there).
> > > * the bool function restore_r2 shouldn't return 2,
> > > that's a little confusing.
> > > * Test whether the compiler supports -mprofile-kernel
> > > and only then define CC_USING_MPROFILE_KERNEL
> > > * also make the return value of klp_check_compiler_support
> > > depend on that.
> >
> > Note that there is still needed the extra patch from
> > http://thread.gmane.org/gmane.linux.kernel/2093867/focus=2099603
> > to get the livepatching working.
>
> Sorry which extra patch?
Message-ID: <20151203160004.GE8047@pathway.suse.cz>
By Petr Mladek, "Re: [PATCH v4 0/9] ftrace with regs + live patching..."
2015-12-03. It is further up in the function call hierarchy and basically
tells the arch-independent KLP to call the normal entry point on ppc64le, and
that the _mcount call site is 16 bytes further.
> > Both ftrace with regs and live patching works for me with this patch
> > set and the extra patch. So. for the whole patchset:
> >
> > Tested-by: Petr Mladek <pmladek@suse.com>
>
> Can you give me some more info on how you're testing it? What config options,
> toolchain etc.?
>
> For me the series doesn't even boot, even with livepatching disabled.
May indeed be a toolchain issue. I had to fix gcc-4.8.5 to get "notrace" working
for -mprofile-kernel. That's a gcc bug.
What are you using?
The config in the v5 patch series should be waterproof, especially with KLP disabled
ftrace with regs must work (all self-tests succeeded). If you send me your config
(via PM I suggest, spare the lists) I can verify it with the toolchain here.
Petr made a suggestion to reshuffle the config options to have it cleaner;
I suggest to patch that separately.
Torsten
next prev parent reply other threads:[~2016-01-20 9:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 14:45 [PATCH v5 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2) Torsten Duwe
2015-12-04 13:36 ` [PATCH v5 1/9] ppc64 (le): prepare for -mprofile-kernel Torsten Duwe
2015-12-04 13:38 ` [PATCH v5 2/9] ppc64le FTRACE_WITH_REGS implementation Torsten Duwe
2015-12-04 13:39 ` [PATCH v5 3/9] ppc use ftrace_modify_all_code default Torsten Duwe
2015-12-04 13:50 ` [PATCH v5 4/9] ppc64 ftrace_with_regs configuration variables Torsten Duwe
2015-12-04 13:52 ` [PATCH v5 5/9] ppc64 ftrace_with_regs: spare early boot and low level Torsten Duwe
2015-12-04 13:55 ` [PATCH v5 6/9] ppc64 ftrace: disable profiling for some functions Torsten Duwe
2015-12-04 13:57 ` [PATCH v5 7/9] ppc64 ftrace: disable profiling for some files Torsten Duwe
2015-12-04 14:11 ` [PATCH v5 8/9] Implement kernel live patching for ppc64le (ABIv2) Torsten Duwe
2015-12-04 14:13 ` [PATCH v5 9/9] Enable LIVEPATCH to be configured on ppc64le and add livepatch.o if it is selected Torsten Duwe
2016-01-06 14:23 ` Petr Mladek
2016-01-06 14:17 ` [PATCH v5 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2) Petr Mladek
2016-01-20 6:03 ` Michael Ellerman
2016-01-20 9:07 ` Torsten Duwe [this message]
2016-01-20 9:48 ` Petr Mladek
2016-01-21 11:34 ` Petr Mladek
2016-01-21 9:33 ` Jiri Kosina
2016-01-21 12:54 ` Michael Ellerman
2016-01-21 15:06 ` Torsten Duwe
2016-01-21 15:12 ` Torsten Duwe
2016-01-21 21:29 ` Jiri Kosina
2016-01-21 21:56 ` Torsten Duwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120090714.GA7031@lst.de \
--to=duwe@lst.de \
--cc=jkosina@suse.cz \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).