From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934151AbcATJJu (ORCPT ); Wed, 20 Jan 2016 04:09:50 -0500 Received: from down.free-electrons.com ([37.187.137.238]:60483 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933577AbcATJHa (ORCPT ); Wed, 20 Jan 2016 04:07:30 -0500 Date: Wed, 20 Jan 2016 10:07:26 +0100 From: Thomas Petazzoni To: Jisheng Zhang Cc: , , , , , , , , , , , Subject: Re: [PATCH 4/4] net: mvneta: update clocks property and document additional clock-names Message-ID: <20160120100726.46dc8816@free-electrons.com> In-Reply-To: <1453277183-5412-5-git-send-email-jszhang@marvell.com> References: <1453277183-5412-1-git-send-email-jszhang@marvell.com> <1453277183-5412-5-git-send-email-jszhang@marvell.com> Organization: Free Electrons X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Jisheng Zhang, On Wed, 20 Jan 2016 16:06:23 +0800, Jisheng Zhang wrote: > diff --git a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt > index aeea50c..f85b93b 100644 > --- a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt > +++ b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt > @@ -6,12 +6,16 @@ Required properties: > - interrupts: interrupt for the device > - phy: See ethernet.txt file in the same directory. > - phy-mode: See ethernet.txt file in the same directory > -- clocks: a pointer to the reference clock for this device. > +- clocks: Array of clocks required for this device; requires at least one > + for CORE clock. Rather than "Array", I would say "list", so what about: - clocks: List of clocks for this device. At least one clock is mandatory for the core clock. If several clocks are given, then the clock-names property must be used to identify them. > Optional properties: > - tx-csum-limit: maximum mtu supported by port that allow TX checksum. > Value is presented in bytes. If not used, by default 1600B is set for > "marvell,armada-370-neta" and 9800B for others. > +- clock-names: Array of names corresponding to clocks property; shall be > + "core" for CORE clock and "axi" for optional AXI clock. Array -> List. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com