From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935152AbcATKqU (ORCPT ); Wed, 20 Jan 2016 05:46:20 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35275 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934687AbcATKqI (ORCPT ); Wed, 20 Jan 2016 05:46:08 -0500 Date: Wed, 20 Jan 2016 10:45:55 +0000 From: Mark Brown To: Arnd Bergmann Cc: Bard Liao , Oder Chiou , Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20160120104555.GY6588@sirena.org.uk> References: <2238845.aZnycJVYKR@wuerfel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x6I3On15oG0ucwLF" Content-Disposition: inline In-Reply-To: <2238845.aZnycJVYKR@wuerfel> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x6I3On15oG0ucwLF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 20, 2016 at 11:43:48AM +0100, Arnd Bergmann wrote: > The newly added rt5659 codec driver unconditionally defines an > ACPI device match table but then uses ACPI_PTR() to remove the > only reference to it, so we get a harmless build warning: > sound/soc/codecs/rt5659.c:4200:30: warning: 'rt5659_acpi_match' defined but not used [-Wunused-variable] > static struct acpi_device_id rt5659_acpi_match[] = { > This removes the ACPI_PTR() to avoid the warning. Why is this a better fix than conditionally defining the table? --x6I3On15oG0ucwLF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWn2ViAAoJECTWi3JdVIfQogMH/AxFJFkXdcV1cbhLQoflo8M3 F1za7C4wHat0os/ytTyiVGXGeJhCotkQ4vKbY6V1H/SmjZp/qTC/fAI9mSqb/tkH lroGlXnZTl1OaLqf2YYgV8cbk3HGi3ECX5ZSmsuonDGjwRDPQ4TyIgvaiOah801K IcOx1DbaLWOyyRVRAB+CJ3YI35CqPHwOfPomXGd63vfwV3u2k5z5ImmhPXm4jwEW 3CFCxpH3Mmu/6eyAOVbNwdYHtRINWcddeMcGXsnmuZ9e4ntFVOMOSllfWAoJLET+ jGBauHTtEL+y6B/BmBXR04LTE3anY7oFVa0gFYbK9sv1KC68BapOmy6C6PGlBoQ= =sE+a -----END PGP SIGNATURE----- --x6I3On15oG0ucwLF--