From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933258AbcATMAR (ORCPT ); Wed, 20 Jan 2016 07:00:17 -0500 Received: from 8bytes.org ([81.169.241.247]:53895 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932666AbcATMAK (ORCPT ); Wed, 20 Jan 2016 07:00:10 -0500 Date: Wed, 20 Jan 2016 13:00:09 +0100 From: Joerg Roedel To: Wan Zongshun Cc: Wan Zongshun , linux-kernel , iommu@lists.linux-foundation.org, Ray Huang , Borislav Petkov , ken.xue@amd.com Subject: Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices Message-ID: <20160120120008.GC18805@8bytes.org> References: <1451988444-4694-1-git-send-email-vincent.wan@amd.com> <1451988444-4694-6-git-send-email-vincent.wan@amd.com> <20160107120422.GB19149@8bytes.org> <20160108121855.GU18805@8bytes.org> <568FCD4B.4000807@iommu.org> <20160108170145.GW18805@8bytes.org> <5690D723.7020003@iommu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5690D723.7020003@iommu.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vincent, On Sat, Jan 09, 2016 at 05:47:15PM +0800, Wan Zongshun wrote: > If so we will modify some existing amd iommu driver codes, and Can I > merge those into this patch 5/6? or I will create another dedicated > patch to take this action? I think its best to make a seperate patch which makes the call-sites of get_device_id() aware of negative return values. Please queue this patch before the patch that actually converts get_device_id() to return something negative. Joerg