From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Dave Airlie <airlied@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc
Date: Wed, 20 Jan 2016 14:56:52 +0200 [thread overview]
Message-ID: <20160120125652.GC23290@intel.com> (raw)
In-Reply-To: <1453287574-3645-1-git-send-email-colin.king@canonical.com>
On Wed, Jan 20, 2016 at 10:59:34AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Duplicated const, only one is required. Also reformat line to ensure
> it is less than 80 columns wide.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..bb88e3d 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd,
> + struct drm_gem_cma_object **obj,
Seems to have been my mode_cmd constification that added the second
const by accident.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
> --
> 2.7.0.rc3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2016-01-20 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:59 [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc Colin King
2016-01-20 12:56 ` Daniel Vetter
2016-01-20 12:56 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120125652.GC23290@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@redhat.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).