From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933529AbcATM47 (ORCPT ); Wed, 20 Jan 2016 07:56:59 -0500 Received: from mga04.intel.com ([192.55.52.120]:46556 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932347AbcATM44 (ORCPT ); Wed, 20 Jan 2016 07:56:56 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,320,1449561600"; d="scan'208";a="885475284" Date: Wed, 20 Jan 2016 14:56:52 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Colin King Cc: Dave Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc Message-ID: <20160120125652.GC23290@intel.com> References: <1453287574-3645-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453287574-3645-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 10:59:34AM +0000, Colin King wrote: > From: Colin Ian King > > Duplicated const, only one is required. Also reformat line to ensure > it is less than 80 columns wide. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c > index c895b6f..bb88e3d 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = { > }; > > static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev, > - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj, > + const struct drm_mode_fb_cmd2 *mode_cmd, > + struct drm_gem_cma_object **obj, Seems to have been my mode_cmd constification that added the second const by accident. Reviewed-by: Ville Syrjälä > unsigned int num_planes) > { > struct drm_fb_cma *fb_cma; > -- > 2.7.0.rc3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC