From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933669AbcATNWE (ORCPT ); Wed, 20 Jan 2016 08:22:04 -0500 Received: from mail-am1on0122.outbound.protection.outlook.com ([157.56.112.122]:40992 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932347AbcATNWC convert rfc822-to-8bit (ORCPT ); Wed, 20 Jan 2016 08:22:02 -0500 From: "Gujulan Elango, Hari Prasath (H.)" To: "gregkh@linuxfoundation.org" , "mateusz.kulikowski@gmail.com" , "vthakkar1994@gmail.com" , "DHANAPAL, GNANACHANDRAN (G.)" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH] staging: rtl8192e: prefer using eth_broadcast_addr() Thread-Topic: [PATCH] staging: rtl8192e: prefer using eth_broadcast_addr() Thread-Index: AQHRU4NXEYBuQSsUrkiH40/5BNDiNw== Date: Wed, 20 Jan 2016 13:06:13 +0000 Message-ID: <20160120130716.GA11131@IND12F0122> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hgujulan@visteon.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [91.212.132.116] x-microsoft-exchange-diagnostics: 1;AMSPR06MB487;5:r/oQ+zLV9+znW/N2lBP1Ha4ajcyjzbj+BNRFY22vDv4u1yz77w6ieXxvP4Qbrc1/dEWtKAlNl4Y8K9enPopPMbvKUvoAQsEBM8bTRfDQFBAPVs+57ynH2ULHHUwfTr3o6OBl+MCODJO/Cs02DaB17w==;24:RZEWeg436uBLU5Q3WEFpVEnkCHVo6NiXS1Rjt3qfusj/O6Yw8qQgV0Tn8q+1gzXHh3kiuzTW39nlbxP8AfdxgGrfWB40Vl76rNl617Ld/ZE= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMSPR06MB487; x-ms-office365-filtering-correlation-id: 0eec2007-bb24-47ee-5036-08d3219a79c3 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(208512329853888); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046);SRVR:AMSPR06MB487;BCL:0;PCL:0;RULEID:;SRVR:AMSPR06MB487; x-forefront-prvs: 0827D7ACB9 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(102836003)(81156007)(586003)(2906002)(19580395003)(77096005)(97736004)(1096002)(106356001)(229853001)(86362001)(5002640100001)(105586002)(4326007)(2201001)(575784001)(1076002)(2900100001)(106116001)(2860100001)(3846002)(87936001)(19580405001)(66066001)(6116002)(122556002)(101416001)(189998001)(92566002)(40100003)(50986999)(5001960100002)(5004730100002)(1220700001)(5008740100001)(33656002)(11100500001)(54356999)(4001450100002)(10400500002)(33716001)(2501003)(5001770100001);DIR:OUT;SFP:1102;SCL:1;SRVR:AMSPR06MB487;H:DB5PR06MB1573.eurprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-ID: <41B7E06DCF69994B98F40C49BDDEBD65@eurprd06.prod.outlook.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2016 13:06:13.9488 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR06MB487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hari Prasath Gujulan Elango Prefer using the eth_broadcast_addr() instead of memset to broadcast address 0xFF to the array. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index d0fedb0..2a57640 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -355,9 +355,9 @@ static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee) req->header.frame_ctl = cpu_to_le16(RTLLIB_STYPE_PROBE_REQ); req->header.duration_id = 0; - memset(req->header.addr1, 0xff, ETH_ALEN); + eth_broadcast_addr(req->header.addr1); ether_addr_copy(req->header.addr2, ieee->dev->dev_addr); - memset(req->header.addr3, 0xff, ETH_ALEN); + eth_broadcast_addr(req->header.addr3); tag = (u8 *) skb_put(skb, len + 2 + rate_len); -- 1.9.1