From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758057AbcATVRP (ORCPT ); Wed, 20 Jan 2016 16:17:15 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38024 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbcATVRO (ORCPT ); Wed, 20 Jan 2016 16:17:14 -0500 Date: Wed, 20 Jan 2016 13:17:13 -0800 From: Andrew Morton To: Petr Mladek Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven , Arnd Bergmann , jkosina@suse.com, Geert Uytterhoeven , Russell King - ARM Linux , Daniel Thompson , Peter Zijlstra Subject: Re: [PATCH v4 0/4] Cleaning printk stuff in NMI context Message-Id: <20160120131713.1ee848bc261feadf570274d2@linux-foundation.org> In-Reply-To: <1449840052-10491-1-git-send-email-pmladek@suse.com> References: <1449840052-10491-1-git-send-email-pmladek@suse.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Dec 2015 14:20:48 +0100 Petr Mladek wrote: > this is just a quick respin of the previous version. It changes > the few details as you suggested. Also it fixes the build problem > on ARM as reported by Geert and Arnd. > > I rather send the whole patch set because there is the renamed header. > Also the extra blank space affects two patches. I hope that it will > safe you some work. Please, let me know if you would prefer > incremental patches. > > > Changes against v3: > > + used size_t for "len" and "size" > > + replaced WARN() with pr_err() > > + renamed kernel/printk/printk.h -> internal.h > > + fixed build on ARM (undefined NMI_LOG_BUF_SHIFT) So the review of the v3 patchset was ... inconclusive. And everyone has gone quiet about v4. Probably because you didn't cc the V3 discussion participants when sending out V4. Big mistake, sorry, I can't check everything! But v4 is basically unaltered from v3 so can we please rev this up again? yay or nay? Thanks.