From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934159AbcATO5o (ORCPT ); Wed, 20 Jan 2016 09:57:44 -0500 Received: from mga11.intel.com ([192.55.52.93]:55393 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbcATO5m (ORCPT ); Wed, 20 Jan 2016 09:57:42 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,321,1449561600"; d="scan'208";a="894667686" Date: Wed, 20 Jan 2016 14:57:40 +0000 From: Keith Busch To: Wenbo Wang Cc: axboe@fb.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, wenwei.tao@memblaze.com, stable@vger.kernel.org, Wenbo Wang Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq Message-ID: <20160120145740.GA30512@localhost.localdomain> References: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > From: Wenbo Wang > > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt triggered nvme_process_cq may access nvmeq->q_db just > before it is updated, this could cause kernel panic. > > Signed-off-by: Wenbo Wang > Reviewed-by: Wenwei Tao Looks good, thanks for the fix. Acked-by: Keith Busch