From: Frederic Weisbecker <fweisbec@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Byungchul Park <byungchul.park@lge.com>,
Chris Metcalf <cmetcalf@ezchip.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Christoph Lameter <cl@linux.com>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Mike Galbraith <efault@gmx.de>, Rik van Riel <riel@redhat.com>
Subject: Re: [RFC PATCH 4/4] sched: Upload nohz full CPU load on task enqueue/dequeue
Date: Wed, 20 Jan 2016 17:45:31 +0100 [thread overview]
Message-ID: <20160120164529.GC24537@lerouge> (raw)
In-Reply-To: <alpine.DEB.2.11.1601201601090.3575@nanos>
On Wed, Jan 20, 2016 at 04:11:14PM +0100, Thomas Gleixner wrote:
> On Wed, 20 Jan 2016, Frederic Weisbecker wrote:
> > On Wed, Jan 20, 2016 at 10:09:06AM +0100, Peter Zijlstra wrote:
> > > Also, since when can we have enqueues/dequeues while NOHZ_FULL ? I
> > > thought that was the 1 task 100% cpu case, there are no
> > > enqueues/dequeues there.
> >
> > That's the most optimized case but we can definetly have small moments with
> > more than one task running. For example if we have a workqueue, or such
> > short and quick tasks.
> >
> > If the user makes use of full dynticks for soft isolation (for performance,
> > can live with a few interrupts...), there can be short moments of
> > multitasking.
>
> Again, you are trying to make the second step after the first one is
> completed. We do not even have proper accounting when we have the ONE task
> 100% case and still you try to solve problems beyond that.
>
> If that ONE task gets interrupted, then accounting should take place.
>
> When there is another runnable task then that nohz state needs to be left. You
> can go back to it once the task is alone again.
>
> You are trying to make the complete accounting 'almost' tick independent, but
> approaching that from the tick nohz angle is wrong.
>
> When you really want to go there, and I can see why you want that, then you
> need to solve this from ground up and such a solution has nothing to do with
> any flavour of NOHZ. That simply needs to rework the whole accounting
> machinery and rip out the complete tick dependency. Once you have that your
> NOHZ business falls into place. Any other approach is just duct tape
> engineering.
Alright, let me respawn that series with handling the most simple and common
scenario, which is 100% single task in full dynticks, and anything else keeps
the tick. That will indeed allow us a more incremental approach.
Thanks.
next prev parent reply other threads:[~2016-01-20 16:45 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 16:01 [RFC PATCH 0/4] sched: Improve cpu load accounting with nohz Frederic Weisbecker
2016-01-13 16:01 ` [PATCH 1/4] sched: Don't account tickless CPU load on tick Frederic Weisbecker
2016-01-19 13:08 ` Peter Zijlstra
2016-01-19 16:22 ` Frederic Weisbecker
2016-01-19 18:56 ` Peter Zijlstra
2016-01-19 22:33 ` Frederic Weisbecker
2016-01-20 5:43 ` Byungchul Park
2016-01-20 10:26 ` Byungchul Park
2016-01-28 16:01 ` Frederic Weisbecker
2016-01-29 9:50 ` Peter Zijlstra
2016-02-01 10:05 ` Byungchul Park
2016-02-01 10:09 ` [PATCH] sched: calculate sched_clock_cpu without tick handling during nohz Byungchul Park
2016-02-01 10:34 ` [PATCH 1/4] sched: Don't account tickless CPU load on tick Peter Zijlstra
2016-02-01 23:51 ` Byungchul Park
2016-02-02 0:50 ` Byungchul Park
2016-02-01 6:33 ` Byungchul Park
2016-01-20 8:42 ` Thomas Gleixner
2016-01-20 17:36 ` Frederic Weisbecker
2016-01-22 8:40 ` Byungchul Park
2016-01-13 16:01 ` [PATCH 2/4] sched: Consolidate nohz CPU load update code Frederic Weisbecker
2016-01-14 2:30 ` Byungchul Park
2016-01-19 13:13 ` Peter Zijlstra
2016-01-20 0:51 ` Byungchul Park
2016-01-14 5:18 ` Byungchul Park
2016-01-19 13:13 ` Peter Zijlstra
2016-01-19 16:49 ` Frederic Weisbecker
2016-01-20 1:41 ` Byungchul Park
2016-02-29 11:14 ` [tip:sched/core] sched/fair: " tip-bot for Frederic Weisbecker
2016-01-13 16:01 ` [RFC PATCH 3/4] sched: Move cpu load stats functions above fair queue callbacks Frederic Weisbecker
2016-01-13 16:01 ` [RFC PATCH 4/4] sched: Upload nohz full CPU load on task enqueue/dequeue Frederic Weisbecker
2016-01-19 13:17 ` Peter Zijlstra
2016-01-19 17:03 ` Frederic Weisbecker
2016-01-20 9:09 ` Peter Zijlstra
2016-01-20 14:54 ` Frederic Weisbecker
2016-01-20 15:11 ` Thomas Gleixner
2016-01-20 15:19 ` Christoph Lameter
2016-01-20 16:52 ` Frederic Weisbecker
2016-01-20 16:45 ` Frederic Weisbecker [this message]
2016-01-20 16:56 ` Peter Zijlstra
2016-01-20 17:21 ` Frederic Weisbecker
2016-01-20 18:25 ` Peter Zijlstra
2016-01-21 13:25 ` Frederic Weisbecker
2016-01-20 9:03 ` Thomas Gleixner
2016-01-20 14:31 ` Frederic Weisbecker
2016-01-20 14:43 ` Thomas Gleixner
2016-01-20 16:40 ` Frederic Weisbecker
2016-01-20 16:42 ` Christoph Lameter
2016-01-20 16:47 ` Frederic Weisbecker
2016-01-14 21:19 ` [RFC PATCH 0/4] sched: Improve cpu load accounting with nohz Dietmar Eggemann
2016-01-14 21:27 ` Peter Zijlstra
2016-01-14 22:23 ` Dietmar Eggemann
2016-01-15 7:07 ` Byungchul Park
2016-01-15 16:56 ` Dietmar Eggemann
2016-01-18 0:23 ` Byungchul Park
2016-01-19 13:04 ` Peter Zijlstra
2016-01-20 0:48 ` Byungchul Park
2016-01-20 13:04 ` Dietmar Eggemann
2016-02-29 11:14 ` [tip:sched/core] sched/fair: Avoid using decay_load_missed() with a negative value tip-bot for Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120164529.GC24537@lerouge \
--to=fweisbec@gmail.com \
--cc=byungchul.park@lge.com \
--cc=cl@linux.com \
--cc=cmetcalf@ezchip.com \
--cc=efault@gmx.de \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).