From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934840AbcATRM2 (ORCPT ); Wed, 20 Jan 2016 12:12:28 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53225 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934332AbcATRMZ (ORCPT ); Wed, 20 Jan 2016 12:12:25 -0500 Date: Wed, 20 Jan 2016 09:12:23 -0800 From: Greg KH To: Wenbo Wang Cc: keith.busch@intel.com, axboe@fb.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, wenwei.tao@memblaze.com, stable@vger.kernel.org, Wenbo Wang Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq Message-ID: <20160120171223.GA28243@kroah.com> References: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > From: Wenbo Wang > > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt triggered nvme_process_cq may access nvmeq->q_db just > before it is updated, this could cause kernel panic. > > Signed-off-by: Wenbo Wang > Reviewed-by: Wenwei Tao > --- > drivers/nvme/host/pci.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.