From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964953AbcATSIk (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Jan 2016 13:08:40 -0500
Received: from arroyo.ext.ti.com ([192.94.94.40]:33886 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S934684AbcATSIi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Jan 2016 13:08:38 -0500
Date: Wed, 20 Jan 2016 12:08:33 -0600
From: Bin Liu <b-liu@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: Felipe Balbi <balbi@ti.com>, <balbif@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency
Message-ID: <20160120180833.GA5433@uda0271908>
References: <1749004.q1rSF7t8cz@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1749004.q1rSF7t8cz@wuerfel>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote:
> The phy-am335x driver accidentally selects 'USB_COMMON', which is
> not correct as that symbol should indicate whether USB host or
> target mode is enabled, but it might not:
> 
> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))

Is it possible to have a .config which has either USB nor USB_GADGET
set but AM335X_PHY_USB is set to be in the situation as in the warning
above?

> 
> This changes the 'select' into 'depends on', as it should have
> been initially.

Using 'depends on' causes AM335x_PHY_USB driver unable to built-in,
since USB_COMMON is an invisible option and its defualt is 'M'.

Regards,
-Bin.

> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")
> 
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index c6904742e2aa..29f063c59e1a 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -63,10 +63,10 @@ config AM335X_CONTROL_USB
>  config AM335X_PHY_USB
>  	tristate "AM335x USB PHY Driver"
>  	depends on ARM || COMPILE_TEST
> +	depends on USB_COMMON
>  	select USB_PHY
>  	select AM335X_CONTROL_USB
>  	select NOP_USB_XCEIV
> -	select USB_COMMON
>  	help
>  	  This driver provides PHY support for that phy which part for the
>  	  AM335x SoC.
>